Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: polish #1581

Closed
wants to merge 4 commits into from
Closed

merge: polish #1581

wants to merge 4 commits into from

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Aug 15, 2024

See commit messages.

Checklist

  • Tests for table-specific id cols and delims
  • Parallel import into separate dbs, then attach them?
  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

This is a small thing, really, but it's a detail that helps make error
messages more precise and thus potentially less confusing.  It's easy
enough, so take the care to do it.
Format defaults so they're formatted for the shell like would be
seen/input on the command-line by humans instead of as a Python value.
Rephrases default for argument-less --quiet flag.  Suppresses "(default:
None)" for required options.
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.54%. Comparing base (f5275d0) to head (2a3aec0).
Report is 130 commits behind head on master.

Files with missing lines Patch % Lines
augur/merge.py 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
+ Coverage   70.51%   70.54%   +0.02%     
==========================================
  Files          78       78              
  Lines        8107     8128      +21     
  Branches     1966     1970       +4     
==========================================
+ Hits         5717     5734      +17     
- Misses       2100     2102       +2     
- Partials      290      292       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tsibley tsibley closed this Aug 21, 2024
@tsibley
Copy link
Member Author

tsibley commented Aug 21, 2024

See #1591.

@tsibley tsibley deleted the trs/merge-polish branch August 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant