Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate version bumping for Auspice #2

Open
tsibley opened this issue Mar 8, 2021 · 4 comments
Open

Automate version bumping for Auspice #2

tsibley opened this issue Mar 8, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@tsibley
Copy link
Member

tsibley commented Mar 8, 2021

The recipe for Auspice won't get automatic version bump PRs from Bioconda's "autobump" tooling because the tooling doesn't currently support NPM package sources.

We can add support by writing a class Npm(Hoster) for https://github.com/bioconda/bioconda-utils/blob/master/bioconda_utils/hosters.py and adding test cases to https://github.com/bioconda/bioconda-utils/blob/master/test/hoster_cases.yaml.

@tsibley tsibley added the enhancement New feature or request label Mar 8, 2021
huddlej pushed a commit that referenced this issue Dec 22, 2021
Merge PR bioconda#31612, commits were: 
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * See if ete3 is the issue
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * debug
 * Update meta.yaml
 * Update meta.yaml
 * Update recipes/deeparg/meta.yaml
 * Add deepARG recipe
 * Merge branch 'master' of github.com:jfy133/bioconda-recipes into master
 * Merge branch 'bioconda:master' into master
 * Add deepARG recipe
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge pull request #2 from bioconda/master

Get latest versions
 * Merge pull request #1 from bioconda/master

Get latest GATK recipe
huddlej pushed a commit that referenced this issue Dec 22, 2021
Merge PR bioconda#32017, commits were: 
 * Fix jsonschema requirement
 * Merge branch 'bioconda:master' into master
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * See if ete3 is the issue
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * debug
 * Update meta.yaml
 * Update meta.yaml
 * Update recipes/deeparg/meta.yaml
 * Add deepARG recipe
 * Merge branch 'master' of github.com:jfy133/bioconda-recipes into master
 * Merge branch 'bioconda:master' into master
 * Add deepARG recipe
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge pull request #2 from bioconda/master

Get latest versions
 * Merge pull request #1 from bioconda/master

Get latest GATK recipe
victorlin pushed a commit that referenced this issue Apr 15, 2022
Merge PR bioconda#33979, commits were: 
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * See if ete3 is the issue
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * debug
 * Update meta.yaml
 * Update meta.yaml
 * Update recipes/deeparg/meta.yaml
 * Add deepARG recipe
 * Merge branch 'master' of github.com:jfy133/bioconda-recipes into master
 * Merge branch 'bioconda:master' into master
 * Add deepARG recipe
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge branch 'bioconda:master' into master
 * Merge pull request #2 from bioconda/master

Get latest versions
 * Merge pull request #1 from bioconda/master

Get latest GATK recipe
@victorlin
Copy link
Member

victorlin commented Jun 21, 2022

Another option would be to automate this ourselves instead of relying on Bioconda's autobump tooling.

There could be a workflow in this fork repo or nextstrain/.github that can be called with parameters for feed (e.g. PyPI), feed package name (e.g. nextstrain-augur, and Bioconda recipe name (e.g. augur). This can be used by augur/release.yaml, etc.

Pros:

We'd still need to manually add dependency changes.

@tsibley
Copy link
Member Author

tsibley commented Jun 22, 2022

I'm not necessarily against doing this ourselves—it might be the right option!—but considering this critically…

Is waiting for Bioconda's autobump schedule really a big deal? They seem to happen pretty quickly most of the time. Do we need same day turnaround on releases on all distribution channels? It seems to me that we don't really. If we implement this autobump ourselves outside of the Bioconda framework, then it's choosing to take on another operational thing to maintain. Instead of being impacted by Bioconda's autobump delays/downtime, we'll be impacted by our own. 🙃 One nice part of extending Bioconda's own framework for autoupdates is that we wouldn't be taking on all the operational work of it, just the initial implementation. (Plus, it benefits the rest of the Bioconda community by adding Node support.)

corneliusroemer pushed a commit that referenced this issue Jul 19, 2022
Merge PR bioconda#35412, commits were: 
 * Merge branch 'bioconda:master' into scexecute_bioconda_recipe
 * Merge branch 'scexecute_bioconda_recipe' of github.com:HorvathLab/bioconda-recipes into scexecute_bioconda_recipe
 * Remove data subdirectory from conda package
 * Merge branch 'bioconda:master' into scexecute_bioconda_recipe
 * another try...
 * more logging?
 * hope so? or not?
 * hope so?
 * round in circles...
 * again...
 * another attempt...
 * What can I assume about the test command?
 * Why is this failing?
 * tweak test command, third attempt
 * tweak test command, attempt #2
 * tweak test command
 * add summary
 * Merge branch 'scexecute_bioconda_recipe' of github.com:HorvathLab/bioconda-recipes into scexecute_bioconda_recipe
 * Add licence
 * Merge branch 'bioconda:master' into scexecute_bioconda_recipe
 * Initial bioconda recipe for scexecute and screadcounts
victorlin pushed a commit that referenced this issue Oct 5, 2022
Merge PR bioconda#37241, commits were: 
 * added all difs
 * added diff
 * readded files
 * readded files
 * Merge branch 'master' into update_polystest
 * Merge branch 'master' into update_polystest
 * corrected build number
 * update to new version
 * reset
 * all deleted
 * Merge pull request #2 from bioconda/master

update to biconda
 * corrected folder name
 * corrected folder name
 * set build number to 0
 * added polystst update
tsibley pushed a commit that referenced this issue Oct 26, 2022
Merge PR bioconda#37288, commits were: 
 * Merge branch 'master' into update_polystest
 * corrected version numbers
 * Merge branch 'update_polystest' of github.com:veitveit/bioconda-recipes into update_polystest
 * corrected version numbers
 * Merge branch 'master' into update_polystest
 * Merge branch 'master' into update_polystest
 * Merge branch 'master' into update_polystest
 * Merge branch 'bioconda-master' into update_polystest
 * alreadyd added change
 * small fix
 * added all difs
 * added diff
 * readded files
 * readded files
 * Merge branch 'master' into update_polystest
 * Merge branch 'master' into update_polystest
 * corrected build number
 * update to new version
 * reset
 * all deleted
 * Merge pull request #2 from bioconda/master

update to biconda
 * corrected folder name
 * corrected folder name
 * set build number to 0
 * added polystst update
tsibley pushed a commit that referenced this issue Nov 8, 2022
Merge PR bioconda#37080, commits were: 
 * Update meta.yaml
 * Update meta.yaml
 * Update meta.yaml
 * Merge branch 'master' into master
 * Merge branch 'master' into master
 * Merge pull request bioconda#8 from marcDabad/cvlr_package

new emas commit
 * new emas commit
 * Merge pull request bioconda#7 from marcDabad/cvlr_package

fix variable
 * fix variable
 * Merge branch 'master' into master
 * Merge pull request bioconda#6 from marcDabad/cvlr_package

gcc 2 cc
 * gcc 2 cc
 * Merge branch 'master' into master
 * Merge pull request bioconda#5 from marcDabad/cvlr_package

passes tests in local
 * passes tests in local
 * Merge branch 'master' into master
 * Merge pull request bioconda#4 from marcDabad/cvlr_package

cc
 * cc
 * Merge pull request #3 from marcDabad/cvlr_package

Cvlr package
 * Merge branch 'master' into master
 * Merge branch 'cvlr_package' of https://github.com/marcDabad/bioconda-recipes into cvlr_package
 * cvlr_recipe
 * Merge pull request #2 from marcDabad/cvlr_package

Cvlr package
 * Merge branch 'master' into cvlr_package
 * Merge pull request #1 from bioconda/master

update
 * cvlr_recipe
tsibley pushed a commit that referenced this issue Mar 2, 2023
Merge PR bioconda#39474, commits were: 
 * Merge branch 'master' into update_polystest2
 * Merge branch 'master' into update_polystest2
 * Merge branch 'master' into update_polystest2
 * update
 * added normalization and speed-up
 * Merge branch 'master' of github.com:veitveit/bioconda-recipes
 * Merge pull request #2 from bioconda/master

update to biconda
@corneliusroemer
Copy link
Member

It is quite trivial to write a script to submit a PR, see Nextclade's way of doing things. It can be adapted quote easily I think.

Doesn't mean it wouldn't be good to contribute to the autobumper, but first we should check that they actually would consider it. They are quite busy with many potentially more important things like finally supporting Python 3.11 or keeping CI up - might not have bandwidth to extend autobumper.

@victorlin
Copy link
Member

Is waiting for Bioconda's autobump schedule really a big deal? They seem to happen pretty quickly most of the time. Do we need same day turnaround on releases on all distribution channels?

It's a bigger deal now 2 years later with the addition of Nextstrain's Conda runtime, meaning the full release process for our tools includes waiting (1) for the Bioconda PR to be created and (2) for it to be manually merged. More discussion in nextstrain/conda-base#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Prioritized
Development

No branches or pull requests

3 participants