Add doc page on Redis #1015
Merged
Add doc page on Redis #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start by moving the existing content from the infrastructure page.
Make this distinctively about minor maintenance tasks and set expectations.
The rename is apparent on the add-on page, presumably because of the shift to using Valkey with version 7.2.¹ ¹ https://devcenter.heroku.com/changelog-items/2918
Start by copying steps from 5 → 6 upgrade notes¹ and adding some introductory text. ¹ https://github.com/tsibley/blab-standup/blob/17eb1690b70ca25aa7be7526b7e140e43cf0a1e6/2023-02-17.md
Reduce the amount of first-person wording which made sense for the note form, but not so much in a proper guide.
This can be detected automatically. The same can likely be done with the new instance name (to replace redis-X-N), but I don't want to create a new instance to test this at the moment.
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--pt6y6j
|
Not ready to be merged, but the content (GitHub preview) is ready for review. I'll wait until after doing the 6.2→7.2 upgrade to see if there are any additional details to include before merging. |
tsibley
approved these changes
Sep 19, 2024
This is necessary to test session restoration.
rST is our standard doc format; Markdown is the legacy format.
Initial conversion performed with:
pandoc -f markdown-smart --shift-heading-level-by -1 -t rst-smart docs/redis.md > docs/redis.rst
and then I hand reviewed and made additional edits.
victorlin
force-pushed
the
victorlin/redis-docs
branch
from
343ae06 to
57f9482
Compare
victorlin
force-pushed
the
victorlin/redis-docs
branch
from
b2a4630 to
3bd0531
Compare
tsibley
approved these changes
Sep 26, 2024
genehack
approved these changes
Sep 26, 2024
victorlin
force-pushed
the
victorlin/redis-docs
branch
from
f86cee8 to
18507ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
Docs used for 6.2 → 7.2 upgrade. Reflects lessons learned from the 2 upgrades that have been done so far.
Checklist