Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add height property to Next.js Image #1081

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

victorlin
Copy link
Member

Description of proposed changes

This is not reflected in the type definition for Next.js's Image element, but width and height must be set together.

Related issue(s)

Follow-up to #1072 (comment)

Checklist

This is not reflected in the type definition for Next.js's Image
element, but width and height must be set together.¹

¹ <https://nextjs.org/docs/app/building-your-application/optimizing/images#image-sizing>
@victorlin victorlin requested a review from genehack November 20, 2024 21:18
@victorlin victorlin self-assigned this Nov 20, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-victorlin--6boruv November 20, 2024 21:19 Inactive
@victorlin victorlin merged commit 632ab48 into master Nov 20, 2024
7 checks passed
@victorlin victorlin deleted the victorlin/nextjs-image branch November 20, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants