Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "HPAI in NA" narrative [#1107] #1108

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add "HPAI in NA" narrative [#1107] #1108

merged 2 commits into from
Jan 16, 2025

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Jan 15, 2025

Adds "HPAI in NA" card; re-organizes order of cards in "Featured analyses".

Preview

@genehack genehack requested review from victorlin and trvrb January 15, 2025 17:53
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-add-hpai-n-t85fyt January 15, 2025 17:53 Inactive
static-site/content/featured-analyses.yaml Show resolved Hide resolved
- name: HPAI outbreaks
description: "HPAI outbreak dynamics in North America: 2021-present"
img: hpai_in_na.png
url: /community/narratives/moncla-lab/nextstrain-narrative-hpai-north-america@main/HPAI-in-North-America
Copy link
Member

@victorlin victorlin Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the URL doesn't work in preview because the narrative references a groups dataset, and those don't work on Heroku review apps due to insufficient AWS permissions.

This could be tested by manually deploying to dev.nextstrain.org or just merging and seeing if it works on next.nextstrain.org.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that, but I verified the URL is correct by editing the heroku hostname to just be "nextstrain.org", and verifying that the dataset loads.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the URL doesn't work in preview because the narrative references a groups dataset

Oh, interesting that the narrative is via /community but the dataset is via /groups. I wonder if @lmoncla knows that narratives can be uploaded to groups too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsibley I did not know that! To be honest, we had some confusion trying to figure out how to get this narrative public, so very happy for any suggestions. Also going to tag @ajaeger207 here who put this together

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nod. What you've done is just fine, but it's a bit easier with Groups. It's like uploading a dataset, e.g.

nextstrain remote upload \
    https://nextstrain.org/groups/moncla-lab/narratives/HPAI-in-North-America \
    hpai-north-america-narrative.md

There's a way author images in the Markdown too so that they're embedded in the narrative automatically upon upload instead of having to author an <img> reference an external URL on GitHub.

We should update the narratives documentation and https://github.com/nextstrain/nextstrain-narratives-demo (which I see was used).

static-site/content/featured-analyses.yaml Outdated Show resolved Hide resolved
@genehack genehack force-pushed the add-hpai-narrative-1107 branch from 1425a17 to 38d3fd3 Compare January 15, 2025 19:05
@genehack genehack temporarily deployed to nextstrain-s-add-hpai-n-t85fyt January 15, 2025 19:05 Inactive
@genehack genehack force-pushed the add-hpai-narrative-1107 branch from 38d3fd3 to 5c5b13a Compare January 15, 2025 23:02
@genehack genehack temporarily deployed to nextstrain-s-add-hpai-n-t85fyt January 15, 2025 23:02 Inactive
@genehack genehack force-pushed the add-hpai-narrative-1107 branch from 5c5b13a to 9783ee6 Compare January 15, 2025 23:11
@genehack genehack temporarily deployed to nextstrain-s-add-hpai-n-t85fyt January 15, 2025 23:11 Inactive
@genehack genehack force-pushed the add-hpai-narrative-1107 branch from 9783ee6 to bbe806a Compare January 15, 2025 23:19
@genehack genehack temporarily deployed to nextstrain-s-add-hpai-n-t85fyt January 15, 2025 23:19 Inactive
@genehack genehack force-pushed the add-hpai-narrative-1107 branch from bbe806a to 0f1eddd Compare January 16, 2025 00:18
@genehack genehack temporarily deployed to nextstrain-s-add-hpai-n-t85fyt January 16, 2025 00:19 Inactive
@trvrb
Copy link
Member

trvrb commented Jan 16, 2025

Looks great!

@genehack genehack merged commit e30cf83 into master Jan 16, 2025
8 checks passed
@genehack genehack deleted the add-hpai-narrative-1107 branch January 16, 2025 03:48
@lmoncla
Copy link
Collaborator

lmoncla commented Jan 17, 2025

Thank you so much!! Looks awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants