-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "HPAI in NA" narrative [#1107] #1108
Conversation
- name: HPAI outbreaks | ||
description: "HPAI outbreak dynamics in North America: 2021-present" | ||
img: hpai_in_na.png | ||
url: /community/narratives/moncla-lab/nextstrain-narrative-hpai-north-america@main/HPAI-in-North-America |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that the URL doesn't work in preview because the narrative references a groups dataset, and those don't work on Heroku review apps due to insufficient AWS permissions.
This could be tested by manually deploying to dev.nextstrain.org or just merging and seeing if it works on next.nextstrain.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that, but I verified the URL is correct by editing the heroku hostname to just be "nextstrain.org", and verifying that the dataset loads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that the URL doesn't work in preview because the narrative references a groups dataset
Oh, interesting that the narrative is via /community but the dataset is via /groups. I wonder if @lmoncla knows that narratives can be uploaded to groups too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsibley I did not know that! To be honest, we had some confusion trying to figure out how to get this narrative public, so very happy for any suggestions. Also going to tag @ajaeger207 here who put this together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nod. What you've done is just fine, but it's a bit easier with Groups. It's like uploading a dataset, e.g.
nextstrain remote upload \
https://nextstrain.org/groups/moncla-lab/narratives/HPAI-in-North-America \
hpai-north-america-narrative.md
There's a way author images in the Markdown too so that they're embedded in the narrative automatically upon upload instead of having to author an <img>
reference an external URL on GitHub.
We should update the narratives documentation and https://github.com/nextstrain/nextstrain-narratives-demo (which I see was used).
1425a17
to
38d3fd3
Compare
38d3fd3
to
5c5b13a
Compare
5c5b13a
to
9783ee6
Compare
9783ee6
to
bbe806a
Compare
bbe806a
to
0f1eddd
Compare
Looks great! |
Thank you so much!! Looks awesome! |
Adds "HPAI in NA" card; re-organizes order of cards in "Featured analyses".
Preview