Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest with dengue gene datasets #771

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

j23414
Copy link
Contributor

@j23414 j23414 commented Jan 2, 2024

Description of proposed changes

Per user request, update dengue builds to include E genes as well as whole genome.

Related issue(s)

Checklist

  • Checks pass

@j23414 j23414 linked an issue Jan 2, 2024 that may be closed by this pull request
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-dengue-man-th1myu January 2, 2024 19:59 Inactive
@j23414
Copy link
Contributor Author

j23414 commented Jan 2, 2024

Merging, since Dataset dropdown options look correct:

@j23414 j23414 merged commit 6552687 into master Jan 2, 2024
4 checks passed
@j23414 j23414 deleted the dengue_manifest branch January 2, 2024 20:18
@jameshadfield
Copy link
Member

From reading through the changes here, URLs such as "https://nextstrain.org/dengue/denv1" will now be redirected to "https://nextstrain.org/dengue/denv1/genome". On the live site (which doesn't yet have the changes in this PR) both URLs are valid and return the same dataset, so I presume this is deliberate and part of a migration of URLs to the new format?

@j23414
Copy link
Contributor Author

j23414 commented Jan 2, 2024

Thanks for checking in! This is intentional; I've uploaded files such as dengue_denv1_genome.json with the intention of removing the original dengue_denv1.json files within the next week or month.

Feel free to suggest alternative approaches to display both "genome" and "E" in the Dataset dropdown menu, or on the site. It's quite possible I've missed some preferred route for this or am misunderstanding something.

@jameshadfield
Copy link
Member

This is the best way - auspice doesn't handle mixed levels like .../A + .../A/B well. Just wanted to make sure this path was intentional!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E gene builds
3 participants