-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap splash tiles to use viz screenshots #914
Conversation
Nice! I was a big fan of the styled cards in the early days but they didn't scale well in multiple senses of the word. This should give us a lot more scope to implement new functionality in future. Way beyond this PR, if we end up wanting similar tiles in an automated fashion (/groups/x etc) it's possible to automate their creation using a similar approach to how we converted narratives to PDFs |
Rebasing this onto latest |
83f5f8c
to
c2881fd
Compare
I added a few more things to the PR description to consider if pursuing this direction. Feel free to tweak! |
Rebasing to resolve merge conflicts |
c2881fd
to
44e4a99
Compare
This commit swaps the tiles used on the splash page from the previous doctored electron micrographs to be simple screenshots of the pages / pathogens that are linked to. This has two advantages: 1. It's super simple and no longer requires sourcing a copyright-free image and doctoring it in LunaPic 2. It's a more up front, more transparent window into what you get when you click on a tile I used tree vs map depending on spatial / epi patterns. For pathogens like WNV and Ebola, the map is meaningful and interesting, while for things like H3N2, it's less relevant. I generally tried to stick close to the content that's directly linked and not update coloring, etc..., but I made a couple of exceptions for visual interest.
The swap makes less sense here since clicking does not immediately go to the visualization. However, this is the last place that the electron micrographs are used. Removing them from here removes the need to maintain two separate images per pathogen and removes the need to conditionally include image credit in the footer. Screenshots added for pathogens that weren't included in splash.
Actually there's enough going on in the screenshot swap that I'm going to put those changes back into this PR. This should make it easier to review each batch of related commits. |
44e4a99
to
14cdcb2
Compare
preview (also see final form of splash in #922)
This commit swaps the tiles used on the splash page from the previous doctored electron micrographs to be simple screenshots of the pages / pathogens that are linked to. This has two advantages:
I used tree vs map depending on spatial / epi patterns. For pathogens like WNV and Ebola, the map is meaningful and interesting, while for things like H3N2, it's less relevant. I generally tried to stick close to the content that's directly linked and not update coloring, etc..., but I made a couple of exceptions for visual interest.
Checklist
/pathogens