Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update group cards further #928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update group cards further #928

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f137aea
Set defaultGroupLinks to true [#870]
genehack Jun 21, 2024
875c352
Add `tooltipText` prop to ResourceGroupHeader [#870]
genehack Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static-site/src/pages/groups.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class GroupsPage extends React.Component {

<ListResources
resourceType="dataset"
defaultGroupLinks={true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[crystal ball gazing -- not a request for changes]

Implicit in the original design is that card titles will become links by simply adding the card name to the current URL. It works well for the groups page (e.g. groups + blab), but I don't think it'll work for an individual groups page.¹ We'll probably just disable the links for those pages.

Also, for what it's worth, the ={true} can be dropped, if you prefer.

¹ Depends on how card titles are chosen of course, but the blab group will probably have a "229e" card and /groups/blab/229e is 404.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on how card titles are chosen of course, but the blab group will probably have a "229e" card and /groups/blab/229e is 404.

I would think on the individual groups page, the titles would not include groups/<group_name>. The resourceListingCallback would just return pathPrefix: "groups/<group_name>"? (Maybe I'm completely off here, still catching up on all the ListResources work)

versioned={false}
resourceListingCallback={resourceListingCallback}/>

Expand Down