Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--soloCBwhitelist option not working #5863

Closed
2 tasks done
ulyssebaruchel opened this issue Jun 21, 2024 · 4 comments
Closed
2 tasks done

--soloCBwhitelist option not working #5863

ulyssebaruchel opened this issue Jun 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ulyssebaruchel
Copy link

Have you checked the docs?

Description of the bug

The way --soloCBwhitelist takes an argument does not seem to work because it is written as metadata but the barcode whitelist needs to be in a (value) channel so it can be loaded into the Docker or Singularity container, and a file cannot be part of metadata. Can you fix it, please? Thank you. (I also think that having the solo as either part of the metadata or as a separate value channel in the input would be preferable.)

Command used and terminal output

No response

Relevant files

No response

System information

No response

@ulyssebaruchel ulyssebaruchel added the bug Something isn't working label Jun 21, 2024
@SPPearce
Copy link
Contributor

What module is this an issue for?

@ulyssebaruchel
Copy link
Author

My bad, this is for the Starsolo module (star/starsolo)

matq007 added a commit to matq007/modules that referenced this issue Jul 31, 2024
Whitelist is set as optional because it is only used by `CB_UMI_Simple` and `CB_UMI_Complex`
matq007 added a commit to matq007/modules that referenced this issue Jul 31, 2024
Whitelist is set as optional because it is only used by `CB_UMI_Simple` and `CB_UMI_Complex`
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2024
* fix: wrong stub output files

* fix: issue #5863

Whitelist is set as optional because it is only used by `CB_UMI_Simple` and `CB_UMI_Complex`

* fix: convert star/starsolo from pytest to nf-test

* fix: ignore Summary.csv

* revert: Summary.csv works fine on when tested locally

* Update snapshot

---------

Co-authored-by: Simon Pearce <[email protected]>
@matq007
Copy link
Member

matq007 commented Aug 2, 2024

Can be also closed now? @SPPearce

@matq007
Copy link
Member

matq007 commented Aug 2, 2024

Solved in #6062

@matq007 matq007 closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants