Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest -> Nftest Readwriter #6077

Merged
merged 10 commits into from
Aug 1, 2024
Merged

Pytest -> Nftest Readwriter #6077

merged 10 commits into from
Aug 1, 2024

Conversation

FriederikeHanssen
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen commented Aug 1, 2024

PR contains two changes:

  • Migrate SENTIEON_READWRITER module test from pytest to nftest
  • Allows to input bam and output cram files by using prefix similarly to other modules that convert data. This also enables a wider range of conversions: bam -> merge -> cram

@FriederikeHanssen
Copy link
Contributor Author

Screenshot 2024-08-01 at 15 12 01

@FriederikeHanssen FriederikeHanssen added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@adamrtalbot
Copy link
Contributor

N E X T F L O W  ~  version 24.04.3
  Launching `/home/ubuntu/tests/383906a652037bde7b4222e478bc2ff/meta/mock.nf` [pensive_hodgkin] DSL2 - revision: 3fd844ab48
  WARN: Input tuple does not match tuple declaration in process `SENTIEON_READWRITER` -- offending value: [[id:test], [/nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.methylated.sorted.bam, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.sorted.bam, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.single_end.sorted.bam], [/nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.methylated.sorted.bam.bai, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.sorted.bam.bai, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.single_end.sorted.bam.bai], []]

@FriederikeHanssen
Copy link
Contributor Author

N E X T F L O W  ~  version 24.04.3
  Launching `/home/ubuntu/tests/383906a652037bde7b4222e478bc2ff/meta/mock.nf` [pensive_hodgkin] DSL2 - revision: 3fd844ab48
  WARN: Input tuple does not match tuple declaration in process `SENTIEON_READWRITER` -- offending value: [[id:test], [/nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.methylated.sorted.bam, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.sorted.bam, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.single_end.sorted.bam], [/nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.methylated.sorted.bam.bai, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.paired_end.sorted.bam.bai, /nf-core/test-datasets/modules/data/genomics/sarscov2/illumina/bam/test.single_end.sorted.bam.bai], []]

🤦‍♀️ good catch

@FriederikeHanssen FriederikeHanssen added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit dc12c69 Aug 1, 2024
16 checks passed
@FriederikeHanssen FriederikeHanssen deleted the nftest_readwriter branch August 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants