Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nfschema plugin subwf #6217

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

nvnieuwk
Copy link
Contributor

This PR adds the nf-schema equivalent of utils_nfvalidation_plugin

This PR cannot be merged before nf-schema v2.1.0 has been released. Which needs one more feature ATM (nextflow-io/nf-schema#43)

@nvnieuwk nvnieuwk requested a review from a team as a code owner August 20, 2024 09:36
@nvnieuwk nvnieuwk requested review from koenbossers and removed request for a team August 20, 2024 09:36
@nvnieuwk
Copy link
Contributor Author

Tests are failing because it's using the unreleased nf-schema v2.1.0 (which I tested with a locally installed version of the plugin)

@nvnieuwk nvnieuwk mentioned this pull request Aug 20, 2024
8 tasks
@nvnieuwk
Copy link
Contributor Author

@maxulysse and @adamrtalbot I added the workflow as a mandatory input to the subwf. I also added parameters schema as an optional input. This is optional because in normal pipeline I'd always advise to only set the schema using the validation.parametersSchema config value to keep it consistent for the whole pipeline. It would be wise though to use this input for meta pipelines.

@maxulysse
Copy link
Member

What about the failing tests?

@nvnieuwk
Copy link
Contributor Author

What about the failing tests?

Seems like some other modules were failing, I updated the branch :p

@maxulysse maxulysse added this pull request to the merge queue Aug 26, 2024
Merged via the queue into nf-core:master with commit bbd5a41 Aug 26, 2024
12 checks passed
@nvnieuwk nvnieuwk deleted the subwf/utils_nfschema_plugin branch August 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants