Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: bedtools/nuc #6784

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

new module: bedtools/nuc #6784

wants to merge 14 commits into from

Conversation

lmfaber
Copy link
Contributor

@lmfaber lmfaber commented Oct 15, 2024

PR checklist

Closes #6783

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@lmfaber
Copy link
Contributor Author

lmfaber commented Oct 15, 2024

I just saw that this PR includes commits from an earlier contribution I made (jvarkit/sam2tsv). The changes were merged in the meanwhile. Shall I submit a new PR without these commit messages or is this ok?

@edmundmiller
Copy link
Contributor

I just saw that this PR includes commits from an earlier contribution I made (jvarkit/sam2tsv). The changes were merged in the meanwhile. Shall I submit a new PR without these commit messages or is this ok?

Shouldn't effect the squash really but if you want you can rebase off master and that should remove them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: bedtools/nuc
4 participants