Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start september/october maintainer minutes #2819

Merged
merged 23 commits into from
Oct 29, 2024
Merged

Start september/october maintainer minutes #2819

merged 23 commits into from
Oct 29, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 27, 2024 •
edited by nf-core-bot
Loading

@maxulysse I've added some empty places for you to edit :)

@netlify /blog/2024/maintainers-minutes-2024-10-25

@netlify Netlify
Copy link

netlify bot commented Oct 27, 2024 •
edited
Loading

✅ Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 77481b1
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/6720b712a1f35000089b2206
😎 Deploy Preview https://deploy-preview-2819--nf-core-main-site.netlify.app/blog/2024/maintainers-minutes-2024-10-25
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot deleted a comment from netlify bot Oct 27, 2024
@jfy133
Copy link
Member Author

jfy133 commented Oct 27, 2024

@nf-core-bot fix linting

sateeshperi
sateeshperi reviewed Oct 27, 2024
View reviewed changes
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx Outdated Show resolved Hide resolved
@sateeshperi
Copy link
Contributor

@nf-core-bot fix linting

@sateeshperi @mahesh-panchal
Apply suggestions from code review
5bc6946 
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
@sateeshperi
Copy link
Contributor

@nf-core-bot fix linting

@sateeshperi
Copy link
Contributor

@nf-core-bot fix linting

@jfy133 @mahesh-panchal
Apply suggestions from code review
ae4c268 
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
jfy133
jfy133 commented Oct 28, 2024
View reviewed changes
Copy link
Member Author

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @maxulysse if you give the approval (after removing the template merge), I think we can merge in

@sateeshperi sateeshperi requested a review from maxulysse October 29, 2024 07:05
@jfy133
Copy link
Member Author

jfy133 commented Oct 29, 2024

@maxulysse @sateeshperi @mahesh-panchal can I get my ticky-ticks please? I can't give it myself 😬

@jfy133
Copy link
Member Author

jfy133 commented Oct 29, 2024

Or @FriederikeHanssen ... the previous approval disapeare and I don't know why?!

@sateeshperi sateeshperi merged commit 456abeb into main Oct 29, 2024
12 checks passed
@sateeshperi sateeshperi deleted the maintainers-minutes-oct24 branch October 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce left review comments

@maxulysse maxulysse maxulysse approved these changes

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

@mashehu mashehu Awaiting requested review from mashehu

@mahesh-panchal mahesh-panchal Awaiting requested review from mahesh-panchal

@sateeshperi sateeshperi Awaiting requested review from sateeshperi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jfy133 @sateeshperi @maxulysse @mashehu @mahesh-panchal @SPPearce @nf-core-bot