Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start september/october maintainer minutes #2819

Merged
merged 23 commits into from
Oct 29, 2024
Merged
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e2717ab
Start october minutes
jfy133 Oct 27, 2024
ed0df90
Add template sections for Maxime
jfy133 Oct 27, 2024
ff79378
Update sites/main-site/src/content/blog/2024/maintainers-minutes-2024…
mashehu Oct 27, 2024
be218b8
Apply suggestions from code review
mashehu Oct 27, 2024
8da9f52
Finish Oct. sections
jfy133 Oct 27, 2024
1806650
[automated] Fix code linting
nf-core-bot Oct 27, 2024
cb78626
Apply suggestions from code review
sateeshperi Oct 27, 2024
3c13d82
Apply suggestions from code review
sateeshperi Oct 27, 2024
7a6f1aa
[automated] Fix code linting
nf-core-bot Oct 27, 2024
f8114d5
add author and formatting tidy
sateeshperi Oct 27, 2024
265968d
Merge branch 'main' into maintainers-minutes-oct24
jfy133 Oct 27, 2024
4201a5e
update minutes
sateeshperi Oct 28, 2024
89c0ba1
Merge branch 'main' into maintainers-minutes-oct24
sateeshperi Oct 28, 2024
5bc6946
Apply suggestions from code review
sateeshperi Oct 28, 2024
967b05a
Merge branch 'main' into maintainers-minutes-oct24
sateeshperi Oct 28, 2024
de252ec
[automated] Fix code linting
nf-core-bot Oct 28, 2024
f98ef0c
Update maintainers-minutes-2024-10-25.mdx
maxulysse Oct 28, 2024
bc0e181
[automated] Fix code linting
nf-core-bot Oct 28, 2024
80805be
Update sites/main-site/src/content/blog/2024/maintainers-minutes-2024…
maxulysse Oct 28, 2024
ae4c268
Apply suggestions from code review
jfy133 Oct 28, 2024
09d1736
Apply suggestions from code review
jfy133 Oct 28, 2024
c64df6e
Update sites/main-site/src/content/blog/2024/maintainers-minutes-2024…
mahesh-panchal Oct 29, 2024
77481b1
Merge branch 'main' into maintainers-minutes-oct24
jfy133 Oct 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
---
title: 'Maintainers Minutes: September/October 2024'
subtitle: 'Keeping you informed of the latest maintainers discussions'
pubDate: 2024-10-27T12:00:00+02:00
mashehu marked this conversation as resolved.
Show resolved Hide resolved
headerImage: '/assets/images/blog/maintainers-minutes-2024-07-26/maintainers_duck.png'
headerImageAlt: "Cartoon yellow rubber duck with nf-core logo badge on it's body with the nf-core logo."
mashehu marked this conversation as resolved.
Show resolved Hide resolved
headerImageDim: [250, 250]
embedHeaderImage: true
authors:
- 'jfy133'
- 'MaxUlysse
mashehu marked this conversation as resolved.
Show resolved Hide resolved
label:
- 'maintainers'
---

The 'Maintainers Minutes' aims to further give insight into the workings of the [nf-core maintainers team](/governance#maintainers)
jfy133 marked this conversation as resolved.
Show resolved Hide resolved
by providing brief summaries of the monthly team meetings.

## Overview

In this double post, we discussed the following topics in September and October:
jfy133 marked this conversation as resolved.
Show resolved Hide resolved
jfy133 marked this conversation as resolved.
Show resolved Hide resolved

- XXX SEPT POINT
- XXX SEPT PONINT
- [New way of passing parameters to modules within nf-test scripts](new-way-of-passing-parameters-to-modules-within-nf-test-scripts)
- [Stalled PRs due to waiting for review](stalled-prs-due-to-waiting-for-review)
- [Replacing monolithic `conf/modules.conf` into per module-configs](replacing-monolithic-confmodulesconf-into-per-module-configs)
- [Modification of modules specifications regarding channels](modifications-of-modules-specifications-regarding-channels)

### XXX SEPT POINT

### XXX SEPT POINT

## New way of passing parameters to modules within nf-test scripts

Our nf-core/modules have greatly benefited from the new nf-test implementation.
However one pet peeve for many is the greatly increased number of files that now comes with each module when installing on a pipeline (>100 file pipeline PRs anyone 😱).

Fortunately <Profile username="mahesh-panchal">Mahesh Binzer-Panchal</Profile> has made a [proof of concept](https://github.com/nf-core/modules/pull/5706) to help reduce this number.
sateeshperi marked this conversation as resolved.
Show resolved Hide resolved
By moving parameters into `when` blocks within the main nf-test script file, we can drop the test-only `nextflow.config` file that many modules have 🎉.
sateeshperi marked this conversation as resolved.
Show resolved Hide resolved

The proposal received unanimous approval.
Mahesh will now begin to formalise this by updating the [nf-core/modules specifications](https://nf-co.re/docs/guidelines/components/modules), and we can start to begin adding additional linting tests to help transfer to this system.

:::info
This system only applies to modules nf-test, and should not be used at pipeline level!
:::

## Stalled PRs due to waiting for review
sateeshperi marked this conversation as resolved.
Show resolved Hide resolved

It was raised that regularly get almost-complete module PRs, but sometimes they stall because a reviewer leaves comments but does not come back to re-review.
Even if the module author receives a second approving review, but the author often (because we are nice here at nf-core) doesn't feel comfortable merging without getting the approval from the original reviewer.
sateeshperi marked this conversation as resolved.
Show resolved Hide resolved

After a short discussion we felt that we can add a new reviewing guideline that if all (reasonable) comments have been addressed, and an approval has been given by another reviewer, a PR should be merged after 3 months if the original reviewer did not re-review.
sateeshperi marked this conversation as resolved.
Show resolved Hide resolved

If the original reviewer was temporarily unable to review during this period (Which can happen!), the module can still be corrected in a follow up review.

## Replacing monolithic `conf/modules.conf` into per module-configs
sateeshperi marked this conversation as resolved.
Show resolved Hide resolved

## Modification of modules specifications regarding channels

\- :heart: from your #maintainers team!
Loading