Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template developments #314

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Template developments #314

merged 8 commits into from
Jul 6, 2023

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Jun 30, 2023

PR with template developments.

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Test Suite Report

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Single list val works by using ‘list like’ rule
GenomicsAssayTemplate_2.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_3.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_4.csv A (double) value of 1.5 fails with rule int::inRange 1 2
GenomicsAssayTemplate_5.csv A value of 0 (outside range) fails with rule int::inRange 1 2

@anngvu anngvu requested a review from allaway July 3, 2023 19:54
@anngvu anngvu marked this pull request as ready for review July 3, 2023 19:54
This was linked to issues Jul 3, 2023
Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allaway allaway merged commit 2d19da7 into main Jul 6, 2023
@allaway allaway deleted the template-dev branch July 6, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize protocols template and surface it Template for dataset
3 participants