Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta-qc utils per # 87 #123

Merged
merged 11 commits into from
Sep 5, 2023
Merged

Add meta-qc utils per # 87 #123

merged 11 commits into from
Sep 5, 2023

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Aug 29, 2023

Close issue #87 (basic pass/fail grading, does not cover letter-grading, which has moved to #122).

This is somewhat inefficient and we could still benefit from a specialized validation service, but it's nevertheless an improvement over the status quo regarding re-validation needs as discussed in Slack.

Test meta_qc_dataset and meta_qc_project to see how well they work so far; I know there will be cases where these could still be better.

Also, you might prefer to use manifest_generate now that the API is stable -- should be much more ergonomic to use than the DCA UI, schematic command line, or the Swagger UI.

Some examples:

meta_qc_project("syn51471542") 
meta_qc_project("syn22392179")

Copy link
Collaborator

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - one minor suggested change but not a blocker for merging.

Couple of thoughts:

-- Consistently get 500 error for syn30058753 - not sure if this is a problem with the API or the dataset?
-- For syn50698189, one of the validation failures is '' is too short which I don't really know what it is referring to. Is this as-is from the API?

R/annotation_qc.R Show resolved Hide resolved
R/annotation_qc.R Outdated Show resolved Hide resolved
Co-authored-by: Robert Allaway <[email protected]>
@anngvu
Copy link
Contributor Author

anngvu commented Sep 5, 2023

This is great - one minor suggested change but not a blocker for merging.

Couple of thoughts:

-- Consistently get 500 error for syn30058753 - not sure if this is a problem with the API or the dataset? -- For syn50698189, one of the validation failures is '' is too short which I don't really know what it is referring to. Is this as-is from the API?

@allaway

  • Realized this was a template/data model issue. We can add a check that template can be found in the current model (given name changes, being removed, etc.) since that'll be a good thing to do before even sending it so schematic, and more informative.
  • '' is too short is as-is from the API. I think we can try to re-interpret this as an enhancement.

@anngvu anngvu merged commit 47f5542 into develop Sep 5, 2023
6 of 7 checks passed
@anngvu anngvu linked an issue Sep 6, 2023 that may be closed by this pull request
@anngvu anngvu deleted the feat/metaqc-issue-87 branch October 27, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script to provide basic scoring of annotations
2 participants