Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset features #74

Merged
merged 25 commits into from
Jul 10, 2023
Merged

Dataset features #74

merged 25 commits into from
Jul 10, 2023

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Oct 20, 2022

Dataset utilities:

@anngvu anngvu requested a review from allaway October 20, 2022 15:55
Copy link
Collaborator

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the functions yet.

R/datasets.R Outdated Show resolved Hide resolved
R/datasets.R Outdated Show resolved Hide resolved
R/datasets.R Outdated Show resolved Hide resolved
@anngvu anngvu linked an issue Nov 17, 2022 that may be closed by this pull request
@anngvu anngvu self-assigned this Dec 14, 2022
@anngvu anngvu marked this pull request as draft March 9, 2023 20:51
@anngvu anngvu changed the title Feat/nf datasets Dataset features Jun 29, 2023
@anngvu anngvu linked an issue Jun 29, 2023 that may be closed by this pull request
@anngvu anngvu linked an issue Jul 3, 2023 that may be closed by this pull request
@anngvu anngvu marked this pull request as ready for review July 3, 2023 23:58
@anngvu
Copy link
Contributor Author

anngvu commented Jul 4, 2023

@allaway There is one known test failure in https://github.com/nf-osi/nfportalutils/actions/runs/5449425127/jobs/9913626204?pr=74#step:6:1392 (get_dependency_from_json_schema ) because we updated the data model. It's outside the scope/theme of this PR, so will fix later.

@anngvu anngvu requested a review from allaway July 5, 2023 21:06
Copy link
Collaborator

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I have not tested everything, but I have a dataset that I should be processing in the next week or so and will have the opportunity to do then and flag any issues.

R/datasets.R Show resolved Hide resolved
@anngvu anngvu merged commit c0c2fd9 into develop Jul 10, 2023
3 of 8 checks passed
@anngvu anngvu deleted the feat/nf-datasets branch October 27, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants