Reduce the padding on main wrapper on mobile #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
previously approved these changes
Aug 29, 2024
|
I wonder if the change from padding to margin might cause any layout issues? Would be good to check layout in templates which don't have a header (eg things within the app). |
frankieroberto
previously approved these changes
Sep 9, 2024
Human error 😮💨 … didn't mean to change them to margin. Changed back, good spot thanks. |
…educe-main-wrapper-padding-on-mobile
edwardhorsford
previously approved these changes
Sep 10, 2024
frankieroberto
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the main wrapper's margin top and bottom on mobile. It currently only changes by 8px, this PR makes it change more between mobile and desktop, from: 40px to 48px, to: 24px to 48px.
Prompted by and related to spacing updates in: #1002
nhsuk-main-wrappernhsuk-main-wrapper--lnhsuk-main-wrapper--sChecklist