Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the padding on main wrapper on mobile #1003

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Reduce the padding on main wrapper on mobile #1003

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
75cc613
reduce the padding on main wrapper on mobile
anandamaryon1 Aug 28, 2024
91afe22
tweak main wrapper margin
anandamaryon1 Aug 28, 2024
5b300a3
Merge branch 'main' into reduce-main-wrapper-padding-on-mobile
anandamaryon1 Sep 9, 2024
e385677
still trying to fix linting error
anandamaryon1 Sep 9, 2024
e8e3cb0
change margins to padding
anandamaryon1 Sep 9, 2024
28b4386
backstop refs
anandamaryon1 Sep 9, 2024
b982a8c
Merge branch 'main' of https://github.com/nhsuk/nhsuk-frontend into r…
anandamaryon1 Sep 10, 2024
2d7c248
backstop refs
anandamaryon1 Sep 10, 2024
e89fff6
changelog
anandamaryon1 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions packages/core/objects/_main-wrapper.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,34 @@
* so it uses CSS initial value, which is inline.
*/

@mixin govuk-main-wrapper {
@include nhsuk-responsive-padding(7, "top");
@include nhsuk-responsive-padding(7, "bottom");
@mixin govuk-main-wrapper {
@include top-and-bottom();
display: block; /* [1] */
margin-top: nhsuk-spacing(4);
margin-bottom: nhsuk-spacing(4);

@include mq($from: tablet) {
margin-top: nhsuk-spacing(7);
margin-bottom: nhsuk-spacing(7);
}
}

@mixin govuk-main-wrapper--l {
@include nhsuk-responsive-padding(8, "top");
margin-top: nhsuk-spacing(6);

@include mq($from: tablet) {
margin-top: nhsuk-spacing(8);
}
}

@mixin govuk-main-wrapper--s {
@include nhsuk-responsive-padding(5, "bottom");
@include nhsuk-responsive-padding(5, "top");
margin-top: nhsuk-spacing(3);
margin-bottom: nhsuk-spacing(3);

@include mq($from: tablet) {
margin-top: nhsuk-spacing(4);
margin-bottom: nhsuk-spacing(4);
}
}

@include govuk-exports("govuk/objects/main-wrapper") {
Expand Down
Loading