Introduce webpack and update eslint #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nikgraf
commented
Sep 8, 2015
nikgraf
commented
- Internal Breaking Change: removed the 'Belle ' prefix fro display name.
- Introduced webpack for docs & examples.
- Upgraded eslint config
- Moved test-suite
- Removed all the custom copy/paste/delete scripts
…ect, Separator, TextInput, Toggle): update display name
| @@ -4,6 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## To Be Released | |||
|
|
|||
| ### Changed | |||
| - [Button, Card, Choice, ComboBox, Option, Placeholder, Rating, Select, Separator, TextInput, Toggle] Removed the 'Belle ' prefix from displayName | |||
|
|
|||
There was a problem hiding this comment.
Hey Nik,
Just to double check, change in display name will not effect anyone already using belle.
There was a problem hiding this comment.
No and yes 😄
displayName is usually only used for debugging. Internally we also used it for propType checks. Some other people might have done the same. So if we want to comply to Semantic Versioning we would need to upgrade to 2.0 because it's a breaking change.
An alternative would be to fix this bug and go back to the old names: gaearon/babel-plugin-react-transform#15
Might be the best solution. Since we didn't really change components we can merge this now and take care about it before we do another release.
|
Great work Nik. |
jpuri
added a commit
that referenced
this pull request
Sep 9, 2015
Introduce webpack and update eslint
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.