-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce webpack and update eslint #183
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1e4c203
chore(depedencies): upgrade
nikgraf 3588c5a
chore(webpack): first working webpack version for docs
nikgraf 64cea41
chore(webpack): migrateo to react-transform-boilerplate
nikgraf 5fa5bc5
feat(Button, Card, Choice, ComboBox, Option, Placeholder, Rating, Sel…
nikgraf d68bf02
chore(webpack): migrate examples playground to webpack
nikgraf 523ac84
chore(tests): move tests into source, but ignore them for the build step
nikgraf 3349417
doc(Readme): update development instructions
nikgraf 7db65f8
chore(eslint): update eslint setup and introduce command
nikgraf 557c66c
fix(ComboBox, Rating, Select, animations, test): comply to new eslint…
nikgraf ef47b2e
doc(changelog): update changelog
nikgraf efc48ff
fix(tests): fix test suite by only ignoring __test__ directory during…
nikgraf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"stage": 0, | ||
"plugins": [ | ||
"react-transform" | ||
], | ||
"extra": { | ||
"react-transform": [{ | ||
"target": "react-transform-webpack-hmr", | ||
"imports": ["react"], | ||
"locals": ["module"] | ||
}, { | ||
"target": "react-transform-catch-errors", | ||
"imports": ["react", "redbox-react"] | ||
}] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,18 @@ | ||
Belle Documentation | ||
================ | ||
|
||
## Setup | ||
## Install | ||
|
||
``` | ||
npm install | ||
``` | ||
|
||
Note: To make the development setup as easy as possible `npm install` will copy | ||
the code styles from node_modules & establish a symlink from inside node_modules | ||
to the root of the belle directory. Ideally `npm link` could be used, but it | ||
doesn't play well with `peerDependencies` -> [Issue](https://github.com/npm/npm/issues/5875). | ||
Make sure you ran `npm install` in the root folder of Belle. | ||
|
||
## Development Environment | ||
## Run | ||
|
||
``` | ||
npm start | ||
``` | ||
|
||
The app will run with hot reloading on `http://localhost:3000`. |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Nik,
Just to double check, change in display name will not effect anyone already using belle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No and yes 😄
displayName is usually only used for debugging. Internally we also used it for propType checks. Some other people might have done the same. So if we want to comply to Semantic Versioning we would need to upgrade to 2.0 because it's a breaking change.
An alternative would be to fix this bug and go back to the old names: gaearon/babel-plugin-react-transform#15
Might be the best solution. Since we didn't really change components we can merge this now and take care about it before we do another release.