This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: deep revision and refactor of the GP modeling
I tried to migrate the cross-validation to only use Scikit-learn CV utilities. At first, Scikit-learn wanted our ``eddymotion.model._dipy.GaussianProcessModel`` to be a sklearn's Estimator. That made me realize that the boundaries between Scikit-learn, DIPY, and eddymotion weren't clear. This commit: * Separates our old ``_dipy`` module into two modules, moving all Scikit-learn-related types into a new ``_sklearn`` module. * Type-annotates and completes docstrings of most of the code. * Updates the test script ``dwi_estimation_error_analysis.py`` to employ the new code.
- Loading branch information
Showing
5 changed files
with
802 additions
and
458 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.