This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
ENH: Improve CLI of the dwi/error experiment #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
fix/dwi_experiment_improvements
branch
3 times, most recently
from
5797dfd to
6489c60
Compare
jhlegarreta
previously approved these changes
Oct 29, 2024
Co-authored-by: Jon Haitz Legarreta Gorroño <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage ? 66.24%
=======================================
Files ? 19
Lines ? 942
Branches ? 119
=======================================
Hits ? 624
Misses ? 274
Partials ? 44 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to optional many arguments so that the script is easier to call (previously, you needed to check the right ordering always and positional parameters are very easy to mix-up).
It also makes optional several features: writing the generated synthetic data, writing the predictions, and the k-fold cross validation (added a single-run possibility useful for debugging).