Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

ENH: Add GP estimation notebook #255

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

jhlegarreta
Copy link
Collaborator

Add GP estimation notebook.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (795a9b7) to head (cbff151).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          19       19           
  Lines         942      942           
  Branches      119      119           
=======================================
  Hits          624      624           
  Misses        274      274           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta jhlegarreta force-pushed the AddGPEstimationNotebook branch 6 times, most recently from d28c6e1 to 85b9aa9 Compare November 5, 2024 12:53
Add GP estimation notebook.
@jhlegarreta jhlegarreta force-pushed the AddGPEstimationNotebook branch from 85b9aa9 to 93d641e Compare November 5, 2024 21:09
@jhlegarreta
Copy link
Collaborator Author

A few notes:

oesteban and others added 4 commits November 6, 2024 00:16
@jhlegarreta jhlegarreta force-pushed the AddGPEstimationNotebook branch 4 times, most recently from 5e6aad6 to 69b2b6a Compare November 9, 2024 18:53
Lint DWI GP estimation notebook.

Take advantage of the commit to remove the unused random number
generator.
@jhlegarreta jhlegarreta force-pushed the AddGPEstimationNotebook branch from 69b2b6a to cbff151 Compare November 9, 2024 18:55
@jhlegarreta
Copy link
Collaborator Author

For the records, the issues I had when computing the GP and fixed by 03b3e54, they were due to these two lines arranging the data in a different way:

dwi_mask = np.repeat(brain_mask[..., np.newaxis], shell_data.shape[-1], axis=-1)
y = shell_data[dwi_mask]
y_train = y.reshape((X_train.shape[0], -1))

wrt to:

y = shell_data[brain_mask]
y_train = y.T

(in the example above I am pretending all data is used for the GP fit to remove any effect of the DWI train_test_mask)

Thanks Óscar, for having taken another, simpler approach in 03b3e54 that allowed to get around the issue.

Ready to be merged.

@jhlegarreta jhlegarreta marked this pull request as ready for review November 9, 2024 22:54
@jhlegarreta jhlegarreta merged commit f10fc12 into nipreps:main Nov 26, 2024
8 checks passed
@jhlegarreta jhlegarreta deleted the AddGPEstimationNotebook branch November 26, 2024 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants