This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
ENH: Add GP estimation notebook #255
Merged
jhlegarreta
merged 6 commits into
nipreps:main
from
jhlegarreta:AddGPEstimationNotebook
Nov 26, 2024
Merged
ENH: Add GP estimation notebook #255
jhlegarreta
merged 6 commits into
nipreps:main
from
jhlegarreta:AddGPEstimationNotebook
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 19 19
Lines 942 942
Branches 119 119
=======================================
Hits 624 624
Misses 274 274
Partials 44 44 ☔ View full report in Codecov by Sentry. |
jhlegarreta
force-pushed
the
AddGPEstimationNotebook
branch
6 times, most recently
from
November 5, 2024 12:53
d28c6e1
to
85b9aa9
Compare
Add GP estimation notebook.
jhlegarreta
force-pushed
the
AddGPEstimationNotebook
branch
from
November 5, 2024 21:09
85b9aa9
to
93d641e
Compare
A few notes:
|
Save the DWI GP estimation notebook figures.
Remove the cross-validation and RMSE computation and plot cells from the GP estimation notebook.
jhlegarreta
force-pushed
the
AddGPEstimationNotebook
branch
4 times, most recently
from
November 9, 2024 18:53
5e6aad6
to
69b2b6a
Compare
Lint DWI GP estimation notebook. Take advantage of the commit to remove the unused random number generator.
jhlegarreta
force-pushed
the
AddGPEstimationNotebook
branch
from
November 9, 2024 18:55
69b2b6a
to
cbff151
Compare
For the records, the issues I had when computing the GP and fixed by 03b3e54, they were due to these two lines arranging the data in a different way:
wrt to:
(in the example above I am pretending all data is used for the GP fit to remove any effect of the DWI train_test_mask) Thanks Óscar, for having taken another, simpler approach in 03b3e54 that allowed to get around the issue. Ready to be merged. |
oesteban
approved these changes
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GP estimation notebook.