Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

ENH: Add bold realignment notebook (ISMRM'25 Experiment 2) #256

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Nov 6, 2024

No description provided.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.24%. Comparing base (3cba47d) to head (5123f50).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/eddymotion/estimator.py 57.89% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          19       19           
  Lines         942      942           
  Branches      119      119           
=======================================
  Hits          624      624           
  Misses        274      274           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta
Copy link
Collaborator

jhlegarreta commented Nov 9, 2024

A few comments:

  • skimage and nipreps should be added to pyproject.toml.
  • Do you think that the plots could be transferred immediately or be useful for nireports? If yes, we could transfer them now; if they are useful but not yet ready, we could open an issue there and link to this PR.
  • We need to add the necessary code to retrieve the data and the scripts to preprocess them if applicable (in general for all notebooks; x-ref PR ENH: Add an additional environment to tox to run notebooks #257).

@jhlegarreta
Copy link
Collaborator

@oesteban oesteban marked this pull request as ready for review December 19, 2024 08:57
@oesteban oesteban force-pushed the enh/bold-registration-experiment branch from 0163976 to 5123f50 Compare December 19, 2024 09:44
@oesteban
Copy link
Member Author

Merging so that it starts as part of nifreeze.

@oesteban oesteban merged commit 68f199d into main Dec 19, 2024
8 of 9 checks passed
@oesteban oesteban deleted the enh/bold-registration-experiment branch December 19, 2024 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants