-
Notifications
You must be signed in to change notification settings - Fork 16
DOC: Fix cut passages from README
in documentation index file
#258
Conversation
@effigies tagging you here, as I've seen this commit: I see that it was intended to avoid showing the picture in the Are you OK including the entire Edit: This is what the current documentation index looks like and what this patch set intends to fix: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 19 19
Lines 942 942
Branches 119 119
=======================================
Hits 624 624
Misses 274 274
Partials 44 44 ☔ View full report in Codecov by Sentry. |
@effigies sorry to ping you again here. Can you please review this? |
How about for README.rst: Lines 46 to 54 in f10fc12
We add comments: (single-shell, multi-shell, and diffusion spectrum imaging) using diffusion models available with DIPY [#r5]_.
+.. BEGIN FLOWCHART
.. image:: https://raw.githubusercontent.com/nipreps/eddymotion/507fc9bab86696d5330fd6a86c3870968243aea8/docs/_static/eddymotion-flowchart.svg
:alt: The eddymotion flowchart
+.. END FLOWCHART
.. [#r1] S. Ben-Amitay et al., Motion correction and registration of high b-value diffusion weighted images, Magnetic Then we could instead do: .. include:: ../README.rst
- :end-line: 29
+ :end-before: BEGIN FLOWCHART
.. include:: ../README.rst
- :start-line: 34
+ :start-after: END FLOWCHART See https://docutils.sourceforge.io/docs/ref/rst/directives.html#miscellaneous |
82ba295
to
39faa0b
Compare
1eeb2bd
to
66dc456
Compare
Fix cut passages from `README` in documentation index file: add comments around the flowchart image in the `README` file and change the `start-line` and `end-line` directive pair for the `end-before` and `start-after` pair to skip the flowchart image only. The `start-line` and `end-line` directives were making such that relevant passages of the `README` file providing context for the tool were not being included. Thus the text shown in the documentation index file had some missing parts, and was not making sense.
66dc456
to
e26943b
Compare
I haven't rendered this. Could you share an updated screenshot? |
Fix cut passages from
README
in documentation index file: add comments around the flowchart image in theREADME
file and change thestart-line
andend-line
directive pair for theend-before
andstart-after
pair to skip the flowchart image only.The
start-line
andend-line
directives were making such that relevant passages of theREADME
file providing context for the tool were not being included. Thus the text shown in the documentation index file had some missing parts, and was not making sense.