chore(build): Install Workbench CLI via conda #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
build/workbench-conda
branch
from
4a89f5f to
90a8b72
Compare
|
Ugh, incompatible libzlib (1.3.x) with flirt (1.2.x). I think zlib is supposed to have a stable ABI, so I'm going to see if I can build and use it. Otherwise I could compile with zlib variants and push multiple variants to conda-forge. |
effigies
force-pushed
the
build/workbench-conda
branch
from
90a8b72 to
e8a1072
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3410 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 57 57
Lines 4267 4267
Branches 545 545
=======================================
Hits 3086 3086
- Misses 1061 1065 +4
+ Partials 120 116 -4 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
build/workbench-conda
branch
from
e8a1072 to
a0d44bf
Compare
|
The latest push just slightly amended the Dockerfile: The latest build passed: https://app.circleci.com/pipelines/github/nipreps/fmriprep/2440/workflows/d2c7cdc2-1af9-4737-a71d-8a46e2253805/jobs/12659 |
mgxd
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got connectome-workbench onto conda-forge: https://github.com/conda-forge/connectome-workbench-split-feedstock
It has a connectome-workbench-cli package that excludes the GUI, and now this is one fewer things to have special in the Dockerfile.