-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use consistent skull-stripping pre- and post- SDC #3415
base: master
Are you sure you want to change the base?
fix: Use consistent skull-stripping pre- and post- SDC #3415
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3415 +/- ##
=======================================
Coverage 72.32% 72.33%
=======================================
Files 57 57
Lines 4268 4269 +1
Branches 545 545
=======================================
+ Hits 3087 3088 +1
Misses 1065 1065
Partials 116 116 ☔ View full report in Codecov by Sentry. |
74cbab1
to
3833723
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious if you think sdcflows' brainextraction workflow could be an alternative
That's what this replaces. |
Ah, I missed that in the connections - perhaps we should change this directly in sdcflows then, to keep it consistent across nibabies/nirodents/etc |
I was doing this out here because I didn't want to change that workflow and risk impacting use cases where that wishes well. Really, I think I should just go ahead and use the resampler for unwarping and get rid of the unwarp workflow altogether. |
Hi everyone! Could you merge this version to the master please? Thank you! |
Overall seems safe, the
skullstrip_wf
is extracted from theenhance_and_skullstrip_wf
, skipping reruns.Running locally now. We'll see if does address #3406.