Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use consistent skull-stripping pre- and post- SDC #3415

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Member

Overall seems safe, the skullstrip_wf is extracted from the enhance_and_skullstrip_wf, skipping reruns.

Running locally now. We'll see if does address #3406.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (910c232) to head (3833723).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3415   +/-   ##
=======================================
  Coverage   72.32%   72.33%           
=======================================
  Files          57       57           
  Lines        4268     4269    +1     
  Branches      545      545           
=======================================
+ Hits         3087     3088    +1     
  Misses       1065     1065           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the fix/consistent-bold-skullstripping branch from 74cbab1 to 3833723 Compare December 19, 2024 00:19
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if you think sdcflows' brainextraction workflow could be an alternative

@effigies
Copy link
Member Author

That's what this replaces.

@mgxd
Copy link
Collaborator

mgxd commented Dec 19, 2024

Ah, I missed that in the connections - perhaps we should change this directly in sdcflows then, to keep it consistent across nibabies/nirodents/etc

@effigies
Copy link
Member Author

I was doing this out here because I didn't want to change that workflow and risk impacting use cases where that wishes well. Really, I think I should just go ahead and use the resampler for unwarping and get rid of the unwarp workflow altogether.

@1RuobingLiu
Copy link

Hi everyone! Could you merge this version to the master please? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants