BUG: Fix elapsed runtime format #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
FixElapsedRuntimeFormat
branch
from
1cc485e to
1fedf9f
Compare
|
As an example, for a dataset that took slightly over 24 hours to run, the current implementation showed: instead of |
Fix elapsed runtime format: the `strftime` function `%H` format specifier only supports 0–23 hours (for a single day), thus, when the time exceeds 24 hours, the hours component resets to 0. This patch set computes the elapsed time (per participant and for the entire run), builds a `datetime.timedelta` instance and formats the elapsed time following the `%Hh %Mmin %Ss` formatting using a function created for that purpose. Do not call `time.gmtime` as when reporting the elapsed time we are not interested in the UTC time format.
jhlegarreta
force-pushed
the
FixElapsedRuntimeFormat
branch
from
1fedf9f to
804b055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix elapsed runtime format: the
strftimefunction%Hformat specifier only supports 0–23 hours (for a single day), thus, when the time exceeds 24 hours, the hours component resets to 0.This patch set computes the elapsed time (per participant and for the entire run), builds a
datetime.timedeltainstance and formats the elapsed time following the%Hh %Mmin %Ssformatting using a function created for that purpose.Do not call
time.gmtimeas when reporting the elapsed time we are not interested in the UTC time format.