ENH: Remove redundant DIPY function #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhlegarreta
commented
Jan 9, 2025
•
jhlegarreta
commented
- ENH: Remove redundant DIPY function
- STYLE: Fix style warnings raised by latest ruff release
- ENH: Require Python >= 3.9
jhlegarreta
force-pushed
the
RemoveRedundantDIPYMethod
branch
from
51e032b to
81db00c
Compare
effigies
reviewed
Jan 12, 2025
Remove redundant DIPY `dipy.stats.qc.find_qspace_neighbors` function: DIPY 1.10.0 was released on Dec 12, 2024, and includes the commit where the function at issue was added: https://docs.dipy.org/stable/release_notes/release1.10.html dipy/dipy#3156 Set the minimum required DIPY version to 1.10.0. This patch set will additionally fix the DIPY keyword-only argument warning: ``` mriqc/interfaces/diffusion.py::mriqc.interfaces.diffusion._find_qspace_neighbors /src/mriqc/mriqc/interfaces/diffusion.py:1435: UserWarning: Pass ['bvecs'] as keyword args. From version 2.0.0 passing these as positional arguments will result in an error. gtab = gradient_table(bvals, bvecs) ``` raised for example in: https://app.circleci.com/pipelines/github/nipreps/mriqc/1651/workflows/01145976-37e9-4633-a00b-3ffe27053801/jobs/10057
Fix style warnings raised by latest `ruff` release (v0.9.0, released Jan 9, 2025). Fixes style warnings raised for example in: https://github.com/nipreps/mriqc/actions/runs/12700111857/job/35402136045?pr=1369#step:4:134 `ruff` v0.9.0 release blog post: https://astral.sh/blog/ruff-v0.9.0
jhlegarreta
force-pushed
the
RemoveRedundantDIPYMethod
branch
from
81db00c to
a291e16
Compare
Require Python >= 3.9: Python 3.8 is at EOL since Oct, 7, 2024: https://devguide.python.org/versions/
jhlegarreta
force-pushed
the
RemoveRedundantDIPYMethod
branch
from
29a989c to
8ad9e49
Compare
oesteban
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.