Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Consider warnings as errors when running pytest #1370

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhlegarreta
Copy link
Contributor

Consider warnings as errors when running pytest: add the strict-warnings flag to pytest to consider warnings as errors.

jhlegarreta and others added 2 commits January 9, 2025 18:29
Consider warnings as errors when running `pytest`: add the
`strict-warnings` flag to `pytest` to consider warnings as errors.
@oesteban oesteban enabled auto-merge January 13, 2025 09:25
@oesteban
Copy link
Member

pytest: error: unrecognized arguments: --strict-warnings
  inifile: /src/mriqc/pyproject.toml
  rootdir: /src/mriqc

@jhlegarreta
Copy link
Contributor Author

Yes, there is efforts across other NiPreps repositories to enforce this as well, e.g.
nipreps/nireports#157
nipreps/nifreeze#40

Only the latter seems to be working. There is a discussion with Chris on the nireports PR. It may be worthwhile going over this during the next tech meeting to avoid accumulating technical debt.

PS: Unrelated to the topic and suitable for a tech meeting: should the default branch be renamed to main for the sake of consistency with modern practices/other NiPreps repositories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants