Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

156 add timeStyle field for passFieldContent #163

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

njausteve
Copy link
Owner

Title

Add time_style support and validation to FieldContent struct

Type of Change

  • New feature
  • Refactoring

Description

This PR introduces a new time_style field to the FieldContent struct, allowing for finer control over the display of time formats. The changes include:

  • Adding the time_style field to the struct with appropriate validation.
  • Extending the documentation to describe valid time_style values.
  • Adding test cases to verify the behavior of the time_style field.
  • Refactoring date and number style validation to make the codebase more maintainable.

Testing

  • Added tests to verify that time_style accepts all valid values and raises errors for invalid values.
  • Ensured backward compatibility by testing cases without time_style.

Impact

The changes primarily affect how time is displayed in the FieldContent struct. No performance or security concerns are expected. The system now offers more flexibility in date-time formatting, which could enhance user experiences in scenarios that require precise time displays.

Additional Information

  • Reviewers should focus on the new validation logic for time_style to ensure it aligns with the system's design for date-time formatting.
  • Ensure that the documentation updates correctly describe how to use the new field.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@njausteve
Copy link
Owner Author

closes: #163

@njausteve njausteve merged commit 871ac62 into main Oct 5, 2024
5 checks passed
@njausteve njausteve deleted the 156-add-timeStyle-field-for-passFieldContent branch October 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant