Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2 Support #38

Closed
myungjoo opened this issue Sep 13, 2020 · 3 comments · Fixed by #55, #56, #48, #49 or #50
Closed

ROS2 Support #38

myungjoo opened this issue Sep 13, 2020 · 3 comments · Fixed by #55, #56, #48, #49 or #50
Assignees
@wooksong

Comments

@myungjoo
Copy link
Member

myungjoo commented Sep 13, 2020 •
edited
Loading

We have potential clients who are using ROS2 right now.
(I will have meeting tomorrow and fetch their requirements.)
@wooksong
Copy link
Member

@myungjoo How about branching out for ROS1?

  • ros1 or ros distro name (Melodic?)
  • main (for ros2)

@myungjoo
Copy link
Member Author

Let's not branch out for ROS1 and ROS2.
I'd rather recommend to modularize (e.g., with euphemism: ros-common.c, ros1.c, and ros2.c) or to add #if #endif with build options.

@wooksong
Copy link
Member

@myungjoo Got it. Since build scripts are not compatible with each other, the hierarchies of them would be complex to well organize them. But I understood what you meant.

This was linked to pull requests Nov 3, 2020
[Ros/Src] Refactor tensor_ros_src for ROS1/RosCpp #55
Merged
[Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 #56
Merged
[ROS1/CMake] Modify CMake scripts to support catkin_make #48
Merged
[Build] Import dummy ROS2 publisher #49
Merged
[Msg] Define a custom ROS/ROS2 message #50
Merged
[Refactor] Move the custom type for error code to the virtual class #52
Merged
[Ros2/Sink] Implement the 'enable-save-rosbag' feature #53
Merged
[Dist/Tizen] Revise the rpmspec file to fix gbs-build failure @open sesame 10/15 17:10 #45
Merged
[Ros2/Sink] Add draft of tensor_sink for ROS2 #51
Merged
@wooksong wooksong reopened this Nov 6, 2020
@wooksong wooksong pinned this issue Nov 6, 2020
@wooksong wooksong linked a pull request Nov 6, 2020 that will close this issue
[Dist/Debian] Provide a debian package for nnstreamer-ros2 @open sesame 11/09 18:43 #57
Merged
@wooksong wooksong reopened this Nov 9, 2020
@wooksong wooksong mentioned this issue Nov 9, 2020
Merged
Merged
This was referenced Mar 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wooksong wooksong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ros/Src] Refactor tensor_ros_src for ROS1/RosCpp wooksong/nnstreamer-ros
[Ros2/Src] Add a draft implementation of tensor_ros_src for ROS2 wooksong/nnstreamer-ros
[ROS1/CMake] Modify CMake scripts to support catkin_make wooksong/nnstreamer-ros
[Build] Import dummy ROS2 publisher wooksong/nnstreamer-ros
[Msg] Define a custom ROS/ROS2 message wooksong/nnstreamer-ros
[Refactor] Move the custom type for error code to the virtual class wooksong/nnstreamer-ros
[Ros2/Sink] Implement the 'enable-save-rosbag' feature wooksong/nnstreamer-ros
[Dist/Tizen] Revise the rpmspec file to fix gbs-build failure @open sesame 10/15 17:10 wooksong/nnstreamer-ros
[Ros2/Sink] Add draft of tensor_sink for ROS2 wooksong/nnstreamer-ros
[Dist/Debian] Provide a debian package for nnstreamer-ros2 @open sesame 11/09 18:43 wooksong/nnstreamer-ros
2 participants
@myungjoo @wooksong