Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ros2/Sink] Add draft of tensor_sink for ROS2 #51

Merged
merged 2 commits into from
Oct 28, 2020
Merged

[Ros2/Sink] Add draft of tensor_sink for ROS2 #51

merged 2 commits into from
Oct 28, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Oct 22, 2020 •
edited
Loading

Related to nnstreamer/nnstreamer#2728

This patch adds a draft of the NNStreamer extension plugin, tensor_ros2_sink, that publishes streams of tensors as a ROS2 topic.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #51. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@wooksong wooksong force-pushed the implement-ros2-sink branch from 2d2f5bc to 5cd1a8f Compare October 22, 2020 02:53
@wooksong wooksong changed the title [Ros2/Sink] Add draft of tensor_sink for ROS2 [After #50] [Ros2/Sink] Add draft of tensor_sink for ROS2 Oct 22, 2020
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/51-202010221153350.64200592041016-5cd1a8f95e1e8ebb0d15f3922f288f4ddecf98a4/.

@wooksong wooksong force-pushed the implement-ros2-sink branch 2 times, most recently from b68e1e5 to c80a2c0 Compare October 22, 2020 04:41
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/51-202010221341540.22382807731628-c80a2c0476d7e342b04016bf9810672069ab2ce5/.

@wooksong wooksong force-pushed the implement-ros2-sink branch from c80a2c0 to 5f84ea1 Compare October 22, 2020 04:50
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/51-202010221350550.90679597854614-5f84ea18e425ccb35ddc9d53e0e92e9b2878c35c/.

@wooksong wooksong force-pushed the implement-ros2-sink branch 2 times, most recently from f443843 to ac68a36 Compare October 22, 2020 08:33
@wooksong wooksong changed the title [After #50] [Ros2/Sink] Add draft of tensor_sink for ROS2 [After #52] [Ros2/Sink] Add draft of tensor_sink for ROS2 Oct 22, 2020
myungjoo
myungjoo approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wooksong wooksong force-pushed the implement-ros2-sink branch from ac68a36 to 17277e2 Compare October 27, 2020 04:49
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 27, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/51-202010271349210.32341909408569-17277e217d7f7fca9d1eadf056dc0904b47dec79/.

@wooksong wooksong force-pushed the implement-ros2-sink branch from 17277e2 to 07b76d6 Compare October 27, 2020 09:59
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 27, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/51-202010271859050.42773103713989-07b76d6b93d27f9eea42c028d8fe5824f3ee2b17/.

@wooksong
[Ros2/Sink] Add draft of tensor_sink for ROS2
cb42c7a 
This patch adds a draft of the NNStreamer extension plugin,
tensor_ros2_sink, that publishes streams of tensors as a ROS2 topic.
Note that the property to enable rosbag support is not implemented yet.

Signed-off-by: Wook Song <[email protected]>
@wooksong
[RosPublisher] Revise the nns_ros_publisher's parameters
1308c5b 
This patch revises the nns_rclcpp_publisher's parameters to get the
instance of nns_ros_publisher as the first argument.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong force-pushed the implement-ros2-sink branch from 07b76d6 to 1308c5b Compare October 28, 2020 06:03
@wooksong wooksong changed the title [After #52] [Ros2/Sink] Add draft of tensor_sink for ROS2 [Ros2/Sink] Add draft of tensor_sink for ROS2 Oct 28, 2020
again4you
again4you approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wooksong wooksong merged commit e7ee59d into nnstreamer:main Oct 28, 2020
@wooksong wooksong deleted the implement-ros2-sink branch October 28, 2020 06:41
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
ROS2 Support #38
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@again4you again4you again4you approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROS2 Support
4 participants
@wooksong @taos-ci @again4you @myungjoo