Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Msg] Define a custom ROS/ROS2 message #50

Merged
merged 1 commit into from
Oct 22, 2020
Merged

[Msg] Define a custom ROS/ROS2 message #50

merged 1 commit into from
Oct 22, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Oct 22, 2020 •
edited
Loading

Related to nnstreamer/nnstreamer#2728

This patch defines a custom ROS2 message via reusing the custom ROS1 message, 'tensors'. In addition, relevant codes, CMake scripts, and packaging files are also revised to make this msg compatible with both ROS1 and ROS2.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #50. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/50-202010221018330.46993398666382-af94410cd6da46fccf7182db2cfdcabd66f51227/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/50-202010221059140.24664497375488-24f1c044e262aa18c0c41c44f3fe2afe380f55c0/.

@wooksong
[Msg] Define a custom ROS/ROS2 message
ad70068 
This patch defines a custom ROS2 message via reusing the custom ROS1
message, 'tensors'. In addition, relevant codes, CMake scripts, and
packaging files are also revised to make this msg compatible with both
ROS1 and ROS2.

Signed-off-by: Wook Song <[email protected]>
@wooksong wooksong changed the title [After #49] [Msg] Define a custom ROS/ROS2 message [Msg] Define a custom ROS/ROS2 message Oct 22, 2020
myungjoo
myungjoo approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 9f32c9d into nnstreamer:main Oct 22, 2020
@wooksong wooksong deleted the define-common-msgs branch October 22, 2020 09:45
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
ROS2 Support #38
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

Assignees
No one assigned
Labels
PR/Ready2Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROS2 Support
3 participants
@wooksong @taos-ci @myungjoo