[ trivial ] Fix typo & misspelled function param #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- intY -> incY (incremental index of Y) - __scopy_kernel() only works for interested SIMD register width **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <[email protected]>
skykongkong8
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
djeong20 and
EunjuYang
as code owners
EunjuYang
reviewed
Dec 24, 2024
| @@ -265,23 +265,23 @@ void scopy(const unsigned int N, const void *X, const int incX, void *Y, | |||
| * @param[in] Y float * for Vector Y | |||
| */ | |||
| void scopy(const unsigned int N, const float *X, const int incX, float *Y, | |||
| const int intY); | |||
| const int incY); | |||
| /** | |||
| * @brief copy function : Y = X | |||
| * @param[in] N number of elements in X | |||
| * @param[in] X uint8_t * for Vector X | |||
| * @param[in] Y uint8_t * for Vector Y | |||
| */ | |||
There was a problem hiding this comment.
What about adding explanation on incX and incY?
myungjoo
approved these changes
Dec 24, 2024
- With certain version of compiler, skipping including header file may cause build failure **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <[email protected]>
|
LGTM |
djeong20
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self evaluation: