Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ trivial ] Fix typo & misspelled function param #2838

Merged
merged 2 commits into from
Dec 26, 2024
Merged

[ trivial ] Fix typo & misspelled function param #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6997f
[ trivial ] Fix typo & misspelled function param
skykongkong8 Dec 24, 2024
1c595be
[ trivial ] Add missing header file for quantizer
skykongkong8 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nntrainer/tensor/blas_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ void scopy(const unsigned int N, const float *X, const int incX, float *Y,
}

void scopy(const unsigned int N, const uint8_t *X, const int incX, uint8_t *Y,
const int intY) {
const int incY) {
#ifdef USE_NEON
nntrainer::neon::copy_int8_or_int4(N, X, Y);
#else
Expand Down
8 changes: 4 additions & 4 deletions nntrainer/tensor/blas_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,23 +265,23 @@ void scopy(const unsigned int N, const void *X, const int incX, void *Y,
* @param[in] Y float * for Vector Y
*/
void scopy(const unsigned int N, const float *X, const int incX, float *Y,
const int intY);
const int incY);
/**
* @brief copy function : Y = X
* @param[in] N number of elements in X
* @param[in] X uint8_t * for Vector X
* @param[in] Y uint8_t * for Vector Y
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding explanation on incX and incY?

void scopy(const unsigned int N, const uint8_t *X, const int incX, uint8_t *Y,
const int intY);
const int incY);
/**
* @brief copy function : Y = X
* @param[in] N number of elements in X
* @param[in] X uint8_t * for Vector X
* @param[in] Y float * for Vector Y
*/
void scopy_int4_to_float32(const unsigned int N, const uint8_t *X,
const int incX, float *Y, const int intY);
const int incX, float *Y, const int incY);

/**
* @brief copy function : Y = X
Expand All @@ -290,7 +290,7 @@ void scopy_int4_to_float32(const unsigned int N, const uint8_t *X,
* @param[in] Y float * for Vector Y
*/
void scopy_int8_to_float32(const unsigned int N, const uint8_t *X,
const int incX, float *Y, const int intY);
const int incX, float *Y, const int incY);

/**
* @brief sdot computation : sum of all X * Y
Expand Down
2 changes: 1 addition & 1 deletion nntrainer/tensor/blas_neon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ void custom_scopy(const unsigned int N, const float *X, const int incX,
: "r"(&Y[i]), "r"(&X[i])
: "v0", "memory");
#else
__scopy_kernel(N, X + i, Y + i);
__scopy_kernel(X + i, Y + i);
#endif
}
for (unsigned int i = N4; i < N; ++i) {
Expand Down
1 change: 1 addition & 0 deletions nntrainer/tensor/quantizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#ifdef __cplusplus

#include <tensor.h>
#include <unordered_map>

namespace nntrainer {

Expand Down
Loading