Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Avoid using dirent.h @open sesame 01/15 12:44 #2869

Closed
wants to merge 0 commits into from

Conversation

gkisalapl
Copy link
Contributor

This PR start series of changes which should make possible compilation of nntrainer on windows platform.
Header dirent.h is not available on windows so to make code more portable I've replaced this functionality with std::filesystem

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@jijoongmoon
Copy link
Collaborator

@gkisalapl , Thanks for the PR. It is good if NNTrainer can support Windows Operating System naturally and I'm sure you are working on it. Thanks aging. One thing I want to address is that this Windows Porting task shouldn't be only for windows. I mean this code change also should work in other platform such as android, Linux, etc. So It might be better to use separate build processes, files and defines.

@jijoongmoon jijoongmoon changed the title [Windows] Avoid using dirent.h [Windows] Avoid using dirent.h @open sesame 01/14 08:36 Jan 13, 2025
@DonghakPark DonghakPark changed the title [Windows] Avoid using dirent.h @open sesame 01/14 08:36 [Windows] Avoid using dirent.h @open sesame 01/14 09:23 Jan 14, 2025
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
i will check CI unable to access 'https://github.com/nnstreamer/nntrainer/': The requested URL returned error: 503 it seems like github access error

@gkisalapl
Copy link
Contributor Author

@gkisalapl , Thanks for the PR. It is good if NNTrainer can support Windows Operating System naturally and I'm sure you are working on it. Thanks aging. One thing I want to address is that this Windows Porting task shouldn't be only for windows. I mean this code change also should work in other platform such as android, Linux, etc. So It might be better to use separate build processes, files and defines.

Yes I'm making those changes in the way it works both on windows and linux/android. Draft PR with experimental windows build is exception here - I've focused on proof of concept windows build in this draft PR.

@EunjuYang EunjuYang changed the title [Windows] Avoid using dirent.h @open sesame 01/14 09:23 [Windows] Avoid using dirent.h @open sesame 01/15 12:44 Jan 15, 2025
@DonghakPark
Copy link
Member

Please use rebase command

git rebase upstream/main

@gkisalapl
Copy link
Contributor Author

Please use rebase command

git rebase upstream/main

I've broke rebase operation and create new PR with manual rebase of those changes on top of current main #2884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants