Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Avoid using dirent.h #2884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Windows] Avoid using dirent.h #2884

wants to merge 1 commit into from

Conversation

gkisalapl
Copy link
Contributor

This PR start series of changes which should make possible compilation of nntrainer on windows platform.
Header dirent.h is not available on windows so to make code more portable I've replaced this functionality with std::filesystem

Self-evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

@gkisalapl
Copy link
Contributor Author

It's manual rebase of #2869

@gkisalapl gkisalapl mentioned this pull request Jan 17, 2025
Closed
@myungjoo
Copy link
Member

myungjoo commented Jan 22, 2025 •
edited
Loading

You don't need to close and reopen PR for such reasons. You can ALWAYS overwrite with force push to arbitrary remote branches of yours. Please keep force-pushing to the same PR in the future.

If git rebase main didn't work, you can apply a combination of reset, cherry-pick, apply, format-patch, am, and fetch.

jijoongmoon
jijoongmoon approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EunjuYang
EunjuYang approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkisalapl
Copy link
Contributor Author

You don't need to close and reopen PR for such reasons. You can ALWAYS overwrite with force push to arbitrary remote branches of yours. Please keep force-pushing to the same PR in the future.

If git rebase main didn't work, you can apply a combination of reset, cherry-pick, apply, format-patch, am, and fetch.

Yes, I was not familiar with scheme of work on git used in this project, now I think I'm up to speed with the process.

@gkisalapl
[Windows] Avoid using dirent.h
1845570 
This PR start series of changes which should make possible compilation of nntrainer on windows platform.
Header dirent.h is not available on windows so to make code more portable I've replaced this functionality with std::filesystem

Self-evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Grzegorz Kisala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jijoongmoon jijoongmoon jijoongmoon approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@myungjoo myungjoo myungjoo approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE rebase required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkisalapl @myungjoo @EunjuYang @jijoongmoon