Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: NNstreamer-lite-Native URL with const name #2882

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

DonghakPark
Copy link
Member

Update nnstreamer-lite-native url to const name from date base name

  1. if the cron job of NNStreamer runs and builds at a certain time while the day has changed, the file may not exist due to the interval between those times.
  2. For whatever reason, if NNStreamer fails to perform daily build, the file may not exist.

change --cut-dirs : 6 -> 3

@djeong20 Thank you for working on the URL-related task.
Although it works normally now, using the ZIP file named updated by @gichan-jang would increase stability to prevent failures as much as possible.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Update nnstreamer-lite-native url to const name from date base name
1. if the cron job of NNStreamer runs and builds at a certain time while the day has changed, the file may not exist due to the interval between those times.
2. For whatever reason, if NNStreamer fails to perform daily build, the file may not exist.

change --cut-dirs : 6 -> 3
- "nH" option will remove "https:~~~.com"
- then url has /nnstreamer/latest/android/
- cut 3 dir will make "main" dir on builddir/ml-api-inference

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 321178f into nnstreamer:main Jan 20, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants