This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
All-in-one pull request #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python setup.py sdist bdist_wheel
currently it points to my repo
| @@ -1,7 +1,9 @@ | |||
| tqdm | |||
| ==== | |||
|
|
|||
| Instantly make your loops show a progress meter - just wrap any iterator with "tqdm(iterator)", and you're done! | |||
| [](https://travis-ci.org/kmike/tqdm) | |||
There was a problem hiding this comment.
After merging this line should be changed.
- Sign in to https://travis-ci.org/, go to your Account settings and turn ON the switch near tqdm repo;
- Change this line to show a badge for the official repo:
[](https://travis-ci.org/noamraph/tqdm)
|
Nice PR ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @noamraph,
I've checked #9, #10 and #15 (they all look good) and merged them in a single branch. Also, I've made some other small maintenance-related improvements: Travis CI is enabled, license and Python versions info is added to setup.py, tests now run against more interpreters.
Merging #11 is not needed because it is already covered by #9. I haven't merged #4 because you said you'd like to do some DreamPie changes first. There are few other forks (without PRs), but they diverge from the 'main' source code a bit too much.
tqdm is great because it has sane defaults, easy to use API, and because its per-iteration overhead is low. I haven't found a better progress bar package. Great job! All errors I've encountered ('\n' issue, stdout vs stderr, small Python 3 issues) were fixed either in master or in pull requests.
The only problem is that it is not getting much love now - it seems you don't have time to review pull requests and do releases. This PR is my attempt to make your life a bit easier :) Please tell if I can do anything else to help.