Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun tests on windows (flakes) #690

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Rerun tests on windows (flakes) #690

merged 5 commits into from
Aug 21, 2024
+134 −49

Conversation

makslevental
Copy link
Collaborator

No description provided.

@makslevental makslevental requested a review from newling August 20, 2024 18:36
newling
newling approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@newling newling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer targeting individual tests for repeating or disabling, but this PR is probably way simpler than targeting individual tests on windows so I'm fine with it

@makslevental makslevental force-pushed the makslevental/hack-windows-ci-flakes branch from 5f99e3e to c76ed8b Compare August 21, 2024 05:21
@makslevental makslevental merged commit c95e7fc into main Aug 21, 2024
3 checks passed
@makslevental makslevental deleted the makslevental/hack-windows-ci-flakes branch August 21, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newling newling newling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makslevental @newling