Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun tests on windows (flakes) #690

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Rerun tests on windows (flakes) #690

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32001df
Rerun tests on windows (flakes)
makslevental Aug 20, 2024
78b7995
Update ci.yml
makslevental Aug 20, 2024
5af36b7
Update ci.yml
makslevental Aug 20, 2024
770e003
Update ci.yml
makslevental Aug 20, 2024
c76ed8b
split windows/linux job
makslevental Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ jobs:
uses: actions/cache/restore@v3
with:
path: ${{ env.CACHE_DIR }}
key: "${{ matrix.os }}-build-test-cpp-asserts-v1-${{ github.sha }}"
# without this you'll get collisions ("Failed to save: Unable to reserve cache with key ..., another job may be creating this cache.")
key: "${{ matrix.os }}-build-test-cpp-asserts-v1-${{ github.sha }}-${{ github.event.repository.updated_at }}"
restore-keys: "${{ matrix.os }}-build-test-cpp-"

- name: Build packages
Expand Down Expand Up @@ -115,7 +116,7 @@ jobs:
if: ${{ !cancelled() }}
with:
path: ${{ env.CACHE_DIR }}
key: "${{ matrix.os }}-build-test-cpp-asserts-v1-${{ github.sha }}"
key: "${{ matrix.os }}-build-test-cpp-asserts-v1-${{ github.sha }}-${{ github.event.repository.updated_at }}"

test_linux:
name: E2E Test linux
Expand Down
9 changes: 8 additions & 1 deletion build_tools/ci/build_test_cpp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ echo "Using python: $python"

# https://stackoverflow.com/a/8597411/9045206
# note: on windows (git-bash) result is "msys"
# well only if you have apparently the right version of git-bash installed
# https://stackoverflow.com/a/72164385
if [[ "$OSTYPE" == "linux-gnu"* ]]; then
export CMAKE_TOOLCHAIN_FILE="$this_dir/linux_default_toolchain.cmake"
export CC=clang
Expand Down Expand Up @@ -86,7 +88,12 @@ cmake --build "$build_dir" --target iree-install-dist

echo "CTest"
echo "-----"
ctest --test-dir "$build_dir" -R amd-aie --output-on-failure -j
if [[ "$OSTYPE" == "linux-gnu"* ]]; then
ctest --test-dir "$build_dir" -R amd-aie --output-on-failure -j
else
# hack while windows is flaky to get past failing tests
ctest --test-dir "$build_dir" -R amd-aie --output-on-failure -j --repeat until-pass:5
fi

# Show ccache stats.
ccache --show-stats
Loading