[DmaToNpu] Add packet support for NpuDmaMemcpyNdOp #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhang93
approved these changes
Sep 18, 2024
| @@ -376,6 +376,13 @@ struct DmaToNpuPattern : OpConversionPattern<NpuDmaMemcpyNdOp> { | |||
| // repeat_count | |||
| repeat_count = IntegerAttr::get(i32ty, sizes[3] - 1); | |||
|
|
|||
| // enable_packet | |||
| if (auto packetInfo = op.getPacket()) { | |||
There was a problem hiding this comment.
Where is the first place that packet control is turned on?
There was a problem hiding this comment.
E2E you mean? I have one hacked example working locally that enables it for L3 -> L2 data movement, but I am working on generalizing it.
EDIT: And this is not packet control, but packet routing.
daveliddell
pushed a commit
to daveliddell/iree-amd-aie
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://github.com/Xilinx/mlir-aie/pull/1671/files#diff-2dc661023141402b83d465f580b2aa2e72aad010c1b19da829d1e014fd2d324cR373
Adds packet routing support for
NpuDmaMemcpyNdOp.