Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set paths for tuner and shortfin workflows consistently. #298

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ScottTodd
Copy link
Member

Now these workflows will only run if files in one of these subproject directories are touched.

This sets triggers consistently for pull_request and push events. In other projects we've set all workflows to run on push events. We could do that here too, just in case these triggers miss something prior to merge.

Note that using paths filters on pull_request triggers breaks "required checks". We currently only set pre-commit and Unit Tests and Type Checking (3.11, ubuntu-latest) as required checks though.

Another option is to just always run these workflows with no filters at all. The workflows are using free runners and are pretty fast (~5 minutes), so the predictability could be nice.

@ScottTodd ScottTodd requested a review from marbre October 18, 2024 16:36
@ScottTodd ScottTodd merged commit 752b090 into nod-ai:main Oct 21, 2024
9 checks passed
@ScottTodd ScottTodd deleted the workflow-triggering branch October 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants