Move SGLang related tests #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbre
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
I am not aware on the utilization of mi300x-4, this is something @saienduri could comment on. Beside this, as the workflow didn't run, I cannot say much but not spotting anything wrong in the workflows so far. Fine to land and to iterate afterwards if needed.
NIT: s/Move SGLang Related Tests/Move SGLang related tests
stbaione
added a commit
that referenced
this pull request
Nov 25, 2024
#604) # Description We started seeing a failure in `Shortfin CPU LLM Integration Test` after merging #601. However, the only aspect of the integration test that that PR touches is a fix in the logger: Old ```python logger = logging.getLogger("__name__") ``` New ```python logger = logging.getLogger(__name__) ``` That shouldn't have an impact on the test, and while reading the output of the workflow, it didn't seem to be the line that caused the server to not start. When testing locally in a fresh environment, the test ran fine, which made me think that it may be related to stale dependencies. I updated the hash of cached pip to take into account requirement changes in `sharktank` and `shortfin`, which appears to fix the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from this PR: #590
We have too many tests running on
mi300x-3and need to move the SGLang related ones tomi300x-4.This PR moves the workflows for
sglang_integration_testsandsglang_benchmark_teststo mi300x-4, along with removing the assumption of static MODEL_PATH and TOKENIZER_PATH, downloading them on demand instead.