-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump IREE requirement pins to their latest versions. #835
base: main
Are you sure you want to change the base?
Conversation
This allows the created pull requests to run checks based on the `pull_request` trigger. See the documentation here: * https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs * https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens Tested here: * https://github.com/nod-ai/shark-ai/actions/runs/12819231996/job/35746461928 * #835
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1ea8443
to
06e6cfc
Compare
@@ -55,7 +55,6 @@ def setUp(self): | |||
"--iree-opt-data-tiling=false", | |||
"--iree-preprocessing-pass-pipeline='builtin.module(util.func(iree-preprocessing-generalize-linalg-matmul-experimental))'", | |||
"--iree-stream-resource-memory-model=discrete", | |||
"--iree-hip-legacy-sync=false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell how to update the SDXL files on Azure to fix https://github.com/nod-ai/shark-ai/actions/runs/12834154632/job/35790824168?pr=835#step:7:54 . There are multiple versions of the files on Azure and different parts of this project use different files. Each folder has a full copy of the 12GB+ model artifacts, and it doesn't make sense to fork that many files to remove 1 flag.
subprocess.CalledProcessError: Command '['/home/nod/actions-runner-shark-ai/_work/_tool/Python/3.12.7/x64/bin/python', '-m', 'iree.build', '/home/nod/actions-runner-shark-ai/_work/shark-ai/shark-ai/shortfin/python/shortfin_apps/sd/components/builders.py', '--model-json=sdxl_config_i8.json', '--target=gfx942', '--splat=True', '--build-preference=precompiled', '--output-dir=/home/nod/.cache/shark', '--model=clip', '--iree-hal-target-device=amdgpu', '--iree-hip-target=gfx942', "--iree-compile-extra-args=--iree-hal-target-backends=rocm --iree-hip-target=gfx942 --iree-execution-model=async-external --iree-preprocessing-pass-pipeline='builtin.module(util.func(iree-global-opt-raise-special-ops, iree-flow-canonicalize), iree-preprocessing-transpose-convolution-pipeline, iree-preprocessing-pad-to-intrinsics, util.func(iree-preprocessing-generalize-linalg-matmul-experimental))' --iree-global-opt-propagate-transposes=1 --iree-opt-const-eval=0 --iree-opt-outer-dim-concat=1 --iree-opt-aggressively-propagate-transposes=1 --iree-dispatch-creation-enable-aggressive-fusion --iree-hal-force-indirect-command-buffers --iree-codegen-llvmgpu-use-vector-distribution=1 --iree-llvmgpu-enable-prefetch=1 --iree-codegen-gpu-native-math-precision=1 --iree-hip-legacy-sync=0 --iree-opt-data-tiling=0 --iree-vm-target-truncate-unsupported-floats"]' returned non-zero exit status 1.
ERROR
tests/apps/sd/e2e_test.py::test_sd_server_bs4_dense ERROR
[2/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/sdxl_flagfile_gfx942.txt
[3/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/attention_and_matmul_spec_gfx942.mlir
[4/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/topology_config_spx_single.txt
[5/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/sdxl_config_i8.json
[6/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/sdxl_config_i8.json
[7/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/sdxl_config_i8.json
[8/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/sdxl_config_i8.json
[9/9] Fetch https://sharkpublic.blob.core.windows.net/sharkpublic/sdxl/01062025/configs/sdxl_config_i8.json
Successfully built 9 actions
tests/apps/sd/e2e_test.py::test_sd_server_bs8_percall [2025-01-17 17:52:21.262] [info] [manager.py:28] Created local system with ['amdgpu:0:0@0'] devices
[2025-01-17 17:52:21.[57](https://github.com/nod-ai/shark-ai/actions/runs/12834154632/job/35790824168?pr=835#step:7:58)6] [info] [server.py:250] Preparing runtime artifacts for clip...
unused_prog_name: Unknown command line argument '--iree-hip-legacy-sync=0'. Try: 'unused_prog_name --help'
unused_prog_name: Did you mean '--iree-hip-bc-dir=0'?
Can someone point me to some playbook docs for how to update the hosted files or help get the CI passing again?
Diff: iree-org/iree@iree-3.2.0rc20250113...iree-3.2.0rc20250117
Auto-generated by GitHub Actions using
.github/workflows/update_iree_requirement_pins.yml
.