How should node handle non-existent .env files passed via CLI flags?
#1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… passed via CLI flags?"
|
I would like to close this vote, and for this effect, I'm revealing my key part: |
|
I would like to close this vote, and for this effect, I'm revealing my key part: |
|
I would like to close this vote, and for this effect, I'm revealing my key part: |
Election resultsSubject: How should ResultsWinning candidate: Throw when passed to Table of results
Voting dataParticipants:
Private key to decrypt ballotsDiscarded commitsSome commits have not been taken into account when counting the ballots: [
{
"commitInfo": {
"sha": "eaee90ca0ab9eb2e16efc1be38cd3b7698d0be89",
"signatureStatus": "E",
"author": "Paolo Insogna <[email protected]>",
"files": [
"votes/ShogunPanda.json"
]
},
"reason": "A more recent vote commit from this author has already been counted."
},
{
"commitInfo": {
"sha": "3247caf4bdd14bf138879ce6ef11d63c9d5d1237",
"signatureStatus": "E",
"author": "Chengzhong Wu <[email protected]>",
"files": [
"votes/how-to-handle-missing-env-files/legendecas.json"
]
},
"reason": "A more recent vote commit from this author has already been counted."
},
{
"commitInfo": {
"sha": "68bbfaec60760250ba488d4de3ddd1c6911bd1e4",
"signatureStatus": "E",
"author": "Michael Dawson <[email protected]>",
"files": [
"votes/how-to-handle-missing-env-files/mdawson"
]
},
"reason": "A more recent vote commit from this author has already been counted."
},
{
"commitInfo": {
"sha": "997fa68d26ad50b8bb2265ed29fd76f1146d7a9e",
"signatureStatus": "E",
"author": "Geoffrey Booth <[email protected]>",
"files": [
"votes/how-to-handle-missing-env-files/geoffreybooth.bin"
]
},
"reason": "A more recent vote commit from this author has already been counted."
},
{
"commitInfo": {
"sha": "c82d5122af908e48a6c408ad97c83159f1eba98a",
"signatureStatus": "N",
"author": "Marco Ippolito <[email protected]>",
"files": [
"votes/how-to-handle-missing-env-files/marco-ippolito.json"
]
},
"reason": "A more recent vote commit from this author has already been counted."
}
]Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vote should stay open for 7 days, or until all TSC voting members have cast a ballot.
Vote instructions:
To close the vote, at least 3 secret holder(s)1 must run the following command:
git node vote https://github.com/nodejs/TSC/pull/1581 --decrypt-key-part --post-comment/cc @nodejs/tsc
Current estimated participation: 85%
Footnotes
secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩