Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should node handle non-existent .env files passed via CLI flags? #1581

Merged
merged 25 commits into from
Jun 27, 2024
Merged

How should node handle non-existent .env files passed via CLI flags? #1581

Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4a770fe
Initiate vote for "How should `node` handle non-existent `.env` files…
github-actions[bot] Jun 17, 2024
dcfe92e
Add tniessen's vote
tniessen Jun 17, 2024
c82d512
Add marco-ippolito's vote
marco-ippolito Jun 17, 2024
b5b66ca
vote from aduh95
aduh95 Jun 17, 2024
80a424f
vote from richardlau
richardlau Jun 17, 2024
997fa68
Create geoffreybooth.bin
GeoffreyBooth Jun 17, 2024
057f584
Rename geoffreybooth.bin to geoffreybooth.json
GeoffreyBooth Jun 17, 2024
79e4832
fix: add empty line marco-ippolito.json
marco-ippolito Jun 17, 2024
3e8b601
vote: add RafaelGSS vote
RafaelGSS Jun 17, 2024
ae93bce
vote from MoLow
MoLow Jun 17, 2024
7b9ed3e
add votes from joyee
joyeecheung Jun 17, 2024
6ceba9f
vote
benjamingr Jun 17, 2024
bc37c16
jasnell.json vote
jasnell Jun 17, 2024
3ff3d58
Create Add ronag's vote
ronag Jun 17, 2024
c3a70ec
vote from targos
targos Jun 18, 2024
68bbfae
mdawson vote
mhdawson Jun 19, 2024
40268cf
vote from ruyadorno
ruyadorno Jun 19, 2024
a53b8d0
vote from mcollina
mcollina Jun 19, 2024
3247caf
add vote from legendecas
legendecas Jun 20, 2024
08d28ef
fixup! add vote from legendecas
legendecas Jun 20, 2024
eaee90c
Create ShogunPanda.json
ShogunPanda Jun 24, 2024
4722015
fixup! Create ShogunPanda.json
ShogunPanda Jun 24, 2024
d439037
vote from mhdawson
mhdawson Jun 25, 2024
a24b872
close vote and aggregate results
github-actions[bot] Jun 25, 2024
b810426
Use GitHub handles instead of names
aduh95 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 181 additions & 0 deletions votes/2024-06-25-0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,181 @@
{
"description": "How should `node` handle non-existent `.env` files passed via CLI flags?",
"outcome": {
"winner(s)": [
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`."
]
},
"votes": {
"aduh95": {
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 3,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 4,
"Warn when passed to `--env-file` flag, provide no other flag.": -1,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 4,
"Ignore when passed to `--env-file` flag, provide no other flag.": -1,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 1,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 3
},
"benjamingr": {
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 0,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 50,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 100,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Ignore when passed to `--env-file` flag, provide no other flag.": 90,
"Warn when passed to `--env-file` flag, provide no other flag.": 80
},
"GeoffreyBooth": {
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 2,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 1,
"Warn when passed to `--env-file` flag, provide no other flag.": 4,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 7,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 3,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 6,
"Ignore when passed to `--env-file` flag, provide no other flag.": 5,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 8
},
"jasnell": {
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 0,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 1
},
"joyeecheung": {
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 1,
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 1,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 1,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 1
},
"legendecas": {
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 1,
"Ignore when passed to `--env-file` flag, provide no other flag.": -1,
"Warn when passed to `--env-file` flag, provide no other flag.": 2,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": -1,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 2,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0
},
"marco-ippolito": {
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 10,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 5,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 6,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 7,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 4,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 9,
"Ignore when passed to `--env-file` flag, provide no other flag.": 3,
"Warn when passed to `--env-file` flag, provide no other flag.": 8
},
"mcollina": {
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": -1,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": -1,
"Warn when passed to `--env-file` flag, provide no other flag.": 1,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": -1,
"Ignore when passed to `--env-file` flag, provide no other flag.": 1,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": -1,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": -1,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0
},
"mhdawson": {
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 5,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 6,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 3,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 10,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 4,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 9,
"Ignore when passed to `--env-file` flag, provide no other flag.": 7,
"Warn when passed to `--env-file` flag, provide no other flag.": 8
},
"MoLow": {
"Ignore when passed to `--env-file` flag, provide no other flag.": 6,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 1,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 3,
"Warn when passed to `--env-file` flag, provide no other flag.": 15,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0
},
"RafaelGSS": {
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 1,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": -2,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": -2,
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": -2,
"Warn when passed to `--env-file` flag, provide no other flag.": 2,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": -1
},
"richardlau": {
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": -1,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 2,
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 1,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 2,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": -1
},
"ronag": {
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 0,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 0,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 0
},
"ruyadorno": {
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 30,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 0,
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 10,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 0,
"Ignore when passed to `--env-file` flag, provide no other flag.": 60
},
"ShogunPanda": {
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 0,
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0
},
"targos": {
"Ignore when passed to `--env-file` flag, provide no other flag.": -2,
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": -1,
"Warn when passed to `--env-file` flag, provide no other flag.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": -2,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 0,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 1,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 1
},
"tniessen": {
"Throw when passed to `--env-file` flag, provide no other flag (status quo).": 99,
"Ignore when passed to `--env-file` flag, provide no other flag.": 0,
"Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.": 0,
"Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.": 100,
"Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.": 0,
"Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.": 1,
"Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.": 1,
"Warn when passed to `--env-file` flag, provide no other flag.": 1
}
},
"refs": "https://github.com/nodejs/TSC/pull/1581"
}
Loading