repl: runtime deprecate instantiating without new #54869

avivkeller · 2024-09-09T23:11:31Z

Followup #54842

This PR runtime-deprecates instantiating the REPL classes without the new keyword.

lib/internal/util.js

codecov · 2024-09-10T00:41:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (f0e5b6a) to head (9bf85bc).
Report is 89 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54869      +/-   ##
==========================================
- Coverage   88.43%   88.32%   -0.11%     
==========================================
  Files         654      654              
  Lines      187662   187673      +11     
  Branches    36120    36044      -76     
==========================================
- Hits       165955   165763     -192     
- Misses      14948    15133     +185     
- Partials     6759     6777      +18

Files with missing lines	Coverage Δ
lib/internal/util.js	`97.11% <100.00%> (+0.13%)`	⬆️
lib/repl.js	`94.95% <100.00%> (-0.02%)`	⬇️

... and 29 files with indirect coverage changes

LiviaMedeiros

LGTM with updates to existing codebase. Example:

node/test/parallel/test-repl-preview-without-inspector.js

Line 68 in 741004a

const repl = REPLServer({

avivkeller · 2024-09-10T15:11:08Z

CC @nodejs/repl

jasnell

I think we need a documentation-only deprecation on this first and we need to get a sense of how impactful a runtime deprecation would be on the ecosystem here. Given the nature of the repl module, this would most likely lead to a fair bit of console output noise for modules that are using the repl and users may not actually be able to do anything about it. So let's be careful.

avivkeller · 2024-09-10T15:58:39Z

I think we need a documentation-only deprecation on this first and we need to get a sense of how impactful a runtime deprecation would be on the ecosystem here.

FWIW It has already been doc-deprecated (but very recently).

avivkeller · 2024-09-17T18:00:26Z

@jasnell would you be opposed to landing this in v23 entirely-I'm happy to wait until v24?

jasnell · 2024-09-17T18:10:20Z

I prefer to wait

avivkeller · 2024-09-17T19:11:58Z

Got it. While I'd prefer for this to release in v23, I respect your opinion. I'll look into other optimizations in the meantime.

avivkeller · 2024-09-19T15:32:06Z

@nodejs/tsc per nodejs/Release#1034

My main question is: is this something that could happen in v23? Or should it wait (like @jasnell suggested)?

benjamingr · 2024-09-19T17:21:23Z

I agree with James on this

anonrig · 2024-09-19T17:24:49Z

Let's give people some time to make arrangements, before polluting their console.

mcollina

lgtm

avivkeller · 2024-09-30T13:14:41Z

I've added the blocked label, as this should go out with v24.

@jasnell, Putting aside the 'dont release yet', could you re-review?

lib/repl.js

Co-authored-by: Antoine du Hamel <[email protected]>

avivkeller · 2024-10-29T17:49:29Z

Hey, I assume this needs a new CI since there has been commits since the latest change, can someone start it?

The CITGM shouldn't need a rerun tho (IIUC)

nodejs-github-bot · 2024-10-30T07:10:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63347/

avivkeller · 2024-11-02T15:54:00Z

Can someone restart the fialed build so this can land? Thanks!

nodejs-github-bot · 2024-11-03T06:43:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63402/

avivkeller · 2024-11-03T22:29:48Z

The CI is 📗, can this land 🚀?

nodejs-github-bot · 2024-11-06T21:38:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/54869
✔  Done loading data for nodejs/node/pull/54869
----------------------------------- PR info ------------------------------------
Title      repl: runtime deprecate instantiating without new (#54869)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:repl-deprecate-2 -> nodejs:main
Labels     util, repl, semver-major, author ready, deprecations, needs-ci, needs-citgm, commit-queue-squash
Commits    6
 - repl: runtime deprecate instantiating without new
 - fixup!
 - fixup! fixup!
 - fixup! fixup! fixup!
 - fix flaky test
 - fixup! fix flaky test
Committers 2
 - RedYetiDev <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54869
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54869
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - repl: runtime deprecate instantiating without new
   ⚠  - fixup!
   ⚠  - fixup! fixup!
   ⚠  - fixup! fixup! fixup!
   ⚠  - fix flaky test
   ⚠  - fixup! fix flaky test
   ℹ  This PR was created on Mon, 09 Sep 2024 23:11:31 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54869#pullrequestreview-2383013809
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54869#pullrequestreview-2302928904
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54869#pullrequestreview-2374242695
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54869#pullrequestreview-2397344156
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-03T06:43:31Z: https://ci.nodejs.org/job/node-test-pull-request/63402/
   ℹ  Last CITGM CI on 2024-10-24T21:16:40Z: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3494/
- Querying data for job/node-test-pull-request/63402/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11712304862

nodejs-github-bot · 2024-11-07T08:03:06Z

Landed in 0368f2f

PR-URL: nodejs#54869 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module. labels Sep 9, 2024

avivkeller force-pushed the repl-deprecate-2 branch from bb00db5 to ae8d325 Compare September 9, 2024 23:13

avivkeller added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Sep 9, 2024

avivkeller force-pushed the repl-deprecate-2 branch from ae8d325 to 7f70642 Compare September 9, 2024 23:14

anonrig reviewed Sep 9, 2024

View reviewed changes

lib/internal/util.js Outdated Show resolved Hide resolved

LiviaMedeiros reviewed Sep 10, 2024

View reviewed changes

aduh95 added the needs-citgm PRs that need a CITGM CI run. label Sep 10, 2024

jasnell requested changes Sep 10, 2024

View reviewed changes

avivkeller force-pushed the repl-deprecate-2 branch from 7f70642 to 1ada6a0 Compare September 12, 2024 21:37

avivkeller requested a review from LiviaMedeiros September 12, 2024 21:37

LiviaMedeiros approved these changes Sep 13, 2024

View reviewed changes

avivkeller mentioned this pull request Sep 14, 2024

repl: convert to ES2015 class #54838

Closed

mcollina approved these changes Sep 20, 2024

View reviewed changes

avivkeller added the blocked PRs that are blocked by other issues or PRs. label Sep 30, 2024

avivkeller requested a review from jasnell September 30, 2024 13:14

avivkeller added dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. and removed blocked PRs that are blocked by other issues or PRs. labels Oct 1, 2024

fixup!

e9a2c30

avivkeller force-pushed the repl-deprecate-2 branch from 4235f74 to e9a2c30 Compare October 26, 2024 20:10

fixup! fixup!

391f6e9

avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 26, 2024

aduh95 reviewed Oct 26, 2024

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

Aviv Keller and others added 2 commits October 26, 2024 16:29

fixup! fixup! fixup!

547568c

Co-authored-by: Antoine du Hamel <[email protected]>

fix flaky test

1974e39

avivkeller force-pushed the repl-deprecate-2 branch from 1106f9b to 1974e39 Compare October 28, 2024 20:51

fixup! fix flaky test

9bf85bc

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2024

avivkeller mentioned this pull request Nov 4, 2024

zlib: deprecate classes usage without new #55718

Merged

JakobJingleheimer added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 6, 2024

avivkeller requested a review from JakobJingleheimer November 6, 2024 21:50

avivkeller removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 6, 2024

JakobJingleheimer approved these changes Nov 7, 2024

View reviewed changes

JakobJingleheimer added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2024

nodejs-github-bot merged commit 0368f2f into nodejs:main Nov 7, 2024
67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: runtime deprecate instantiating without new #54869

repl: runtime deprecate instantiating without new #54869

avivkeller commented Sep 9, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

LiviaMedeiros left a comment

avivkeller commented Sep 10, 2024

jasnell left a comment

avivkeller commented Sep 10, 2024

avivkeller commented Sep 17, 2024

jasnell commented Sep 17, 2024

avivkeller commented Sep 17, 2024

avivkeller commented Sep 19, 2024 •

edited

Loading

benjamingr commented Sep 19, 2024

anonrig commented Sep 19, 2024

mcollina left a comment

avivkeller commented Sep 30, 2024 •

edited

Loading

avivkeller commented Oct 29, 2024

nodejs-github-bot commented Oct 30, 2024

avivkeller commented Nov 2, 2024

nodejs-github-bot commented Nov 3, 2024

avivkeller commented Nov 3, 2024 •

edited

Loading

nodejs-github-bot commented Nov 6, 2024

nodejs-github-bot commented Nov 7, 2024

repl: runtime deprecate instantiating without new #54869

repl: runtime deprecate instantiating without new #54869

Conversation

avivkeller commented Sep 9, 2024

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

LiviaMedeiros left a comment

Choose a reason for hiding this comment

avivkeller commented Sep 10, 2024

jasnell left a comment

Choose a reason for hiding this comment

avivkeller commented Sep 10, 2024

avivkeller commented Sep 17, 2024

jasnell commented Sep 17, 2024

avivkeller commented Sep 17, 2024

avivkeller commented Sep 19, 2024 • edited Loading

benjamingr commented Sep 19, 2024

anonrig commented Sep 19, 2024

mcollina left a comment

Choose a reason for hiding this comment

avivkeller commented Sep 30, 2024 • edited Loading

avivkeller commented Oct 29, 2024

nodejs-github-bot commented Oct 30, 2024

avivkeller commented Nov 2, 2024

nodejs-github-bot commented Nov 3, 2024

avivkeller commented Nov 3, 2024 • edited Loading

nodejs-github-bot commented Nov 6, 2024

nodejs-github-bot commented Nov 7, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

avivkeller commented Sep 19, 2024 •

edited

Loading

avivkeller commented Sep 30, 2024 •

edited

Loading

avivkeller commented Nov 3, 2024 •

edited

Loading